-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azlinux3 dnf packages for compiler installation #423
Conversation
If we do this, are we still checking if "CompilerVersion" matches what actually got installed?. Otherwise user might want gcc14 but got gcc11 instead. |
On AzLinux since you can;t specify, user need to either overwrite the compilerVersion to "", or provide a version that matches the version installed |
Actually, let's do this on all other distro as well. Default compiler version to string.empty, and if that happens, install version-less gcc/gfortran etc. If they specify a version, you install gcc-10 etc. On AzLinux, we throw error if user tries to pass in a version |
How should we handle SetGccPriorityAsync when the user does not supply a version? |
… empty for azlinux.
…icrosoft/VirtualClient into users/saibulusu/azlinux3-fixes
Tested LMBench on Ubuntu, CentOS, RHEL, & AzLinux. |
@microsoft-github-policy-service agree |
@microsoft-github-policy-service rerun |
Please also test on SPECcpu, which has more complexity in compiler definition. |
src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs
Outdated
Show resolved
Hide resolved
Please confirm that we will send the compiler version in telemetry properly. Ideally in metrics |
…icrosoft/VirtualClient into users/saibulusu/azlinux3-fixes
For speccpu:
Removed gcc limit in documentation. For Alex's query on compiler version:
|
…ion with metadata.
src/VirtualClient/VirtualClient.Main/profiles/PERF-SPECCPU-FPRATE.json
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but please update the documement for CompilerInstallation on the new behavior
New logic for compiler installation:
azlinux:
version must not be supplied
ubuntu/debian/centos/rhel:
if version is supplied:
install & use supplied version
else:
if version does not exist on system:
install default, then set priority
Tested on azlinux3, jammy.
Further testing for other operating systems to be done in QoS.