Retrieving Disk Paths via DiskManager #440
Conversation
| { | ||
| List<string> diskPaths = new List<string>(); | ||
|
|
||
| return this.Logger.LogMessageAsync($"{nameof(UnixDiskManager)}.GetDiskPaths", EventContext.Persisted(), async () => |
There was a problem hiding this comment.
You only need this wrap if you care about start and ends, do you need that information?
| ErrorReason.DependencyNotFound); | ||
| } | ||
|
|
||
| foreach (Disk disk in disksToTest) |
There was a problem hiding this comment.
If I'm understanding correctly, you just need the extension methods on Disks -> Disk.GetPreferredAccessPath? You don't need to put that into DiskManager if that's the case
There was a problem hiding this comment.
GetPreferredAccessPath is leveraged to get the access paths of all the disks attached / filtered by DiskFilter. Since this method (GetDisks + Filtering Disks + GetPreferredAccessPath) appears in >2 workloads & dependencies, thought it would be appropriate as a method through the disk manager
There was a problem hiding this comment.
If that's the case you should call the GetDisks function above to avoid the duplicated filter code
| ErrorReason.DependencyNotFound); | ||
| } | ||
|
|
||
| if (await this.CreateMountPointsAsync(disksToTest, cancellationToken).ConfigureAwait(false)) |
There was a problem hiding this comment.
In FIO we still need to create mount points,
There was a problem hiding this comment.
I changed the profile to reflect that
No description provided.