Fix registry extraction form .npmrc. #125
Merged
dannyvv merged 3 commits intomicrosoft:mainfrom Feb 4, 2026
Merged
Conversation
…ntication comments like ://
dannyvv
force-pushed
the
pr/FixRegistryFiltering
branch
from
48ecf01 to
4e87f28
Compare
dannyvv
force-pushed
the
pr/FixRegistryFiltering
branch
from
d47eca2 to
5dccd50
Compare
NikoAri
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had false positives for authentication comments like :
//pkgs.dev.azure.com/xyz/abc/npm/registry/=SECRETThis changes makes the key filter stricter. it must be exactly registry for:
registry=https://xyzor ends with:registryfor the@myscope:registry=https://xyz.This change also updates the .npmrc parser for auth tokens and passwords from the current .npmrc file.
This will allow users to use the Azure DevOps task:
npmAuthenticatewhich writes to the file in the source tree.