Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more communication kernels #221

Merged
merged 52 commits into from
Aug 6, 2024
Merged

Add more communication kernels #221

merged 52 commits into from
Aug 6, 2024

Conversation

Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Jul 5, 2024

Add more communication kernels

  • Packet related kernels
  • Fused kernel for recv-reduce-send

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 93.63395% with 24 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (6ae63be) to head (707ab13).

Files Patch % Lines
ark/ops/ops_communication.cpp 93.64% 22 Missing ⚠️
ark/ops/ops_tensor.cpp 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   90.98%   91.32%   +0.34%     
==========================================
  Files         106      106              
  Lines        4106     4475     +369     
==========================================
+ Hits         3736     4087     +351     
- Misses        370      388      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Binyang2014 Binyang2014 marked this pull request as ready for review July 13, 2024 10:41
@Binyang2014 Binyang2014 requested a review from chhwang July 13, 2024 10:41
@Binyang2014 Binyang2014 changed the title Packet allreduce And more communication kernels Jul 13, 2024
@chhwang chhwang changed the base branch from main to chhwang/errors August 3, 2024 03:22
Base automatically changed from chhwang/errors to main August 3, 2024 05:24
@chhwang chhwang changed the base branch from main to chhwang/plan_context August 6, 2024 02:59
Base automatically changed from chhwang/plan_context to main August 6, 2024 07:09
@chhwang chhwang changed the title And more communication kernels Add more communication kernels Aug 6, 2024
ark/include/kernels/comm.h Show resolved Hide resolved
examples/tutorial/multi_gpu_plan.py Outdated Show resolved Hide resolved
@chhwang chhwang merged commit a5b240f into main Aug 6, 2024
9 of 10 checks passed
@chhwang chhwang deleted the binyli/comm branch August 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants