Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up exceptions #229

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Clean up exceptions #229

merged 4 commits into from
Aug 3, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Aug 2, 2024

  • Expose C++ exceptions to the Python module
  • Refine error types

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 43.79562% with 77 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (877b0e6) to head (cf96f0e).

Files Patch % Lines
ark/model/model_op.cpp 0.00% 12 Missing ⚠️
ark/model/model_graph_impl.cpp 0.00% 11 Missing ⚠️
ark/model/model_tensor.cpp 53.33% 7 Missing ⚠️
ark/include/ark/error.hpp 50.00% 5 Missing ⚠️
ark/model/model_json.cpp 77.27% 5 Missing ⚠️
ark/ops/ops_matmul.cpp 50.00% 5 Missing ⚠️
ark/model/model_buffer.cpp 0.00% 4 Missing ⚠️
ark/codegen.cpp 0.00% 3 Missing ⚠️
ark/model/model_op_arg.cpp 0.00% 3 Missing ⚠️
ark/ops/ops_cast.cpp 50.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   90.55%   90.72%   +0.16%     
==========================================
  Files         102      102              
  Lines        3927     3923       -4     
==========================================
+ Hits         3556     3559       +3     
+ Misses        371      364       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chhwang chhwang merged commit dad034d into main Aug 3, 2024
9 of 10 checks passed
@chhwang chhwang deleted the chhwang/errors branch August 3, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant