Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More packages in dev containers #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions docker/base-dev-x.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=ghcr.io/microsoft/ark/ark:base-cuda12.1
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

LABEL maintainer="ARK"
Expand All @@ -10,10 +10,11 @@ ENV ARK_SRC_DIR="/tmp/ark" \
ADD . ${ARK_SRC_DIR}
WORKDIR ${ARK_SRC_DIR}

# Install Lcov
# Install Lcov and clang-format
RUN apt-get update && \
apt-get install -y --no-install-recommends \
lcov \
clang-format \
&& \
apt-get autoremove && \
apt-get clean && \
Expand All @@ -27,6 +28,14 @@ RUN curl -L ${CMAKE_URL} -o ${CMAKE_HOME}.tar.gz && \
rm -rf ${CMAKE_HOME}.tar.gz
ENV PATH="/usr/local/cmake-${CMAKE_VERSION}-linux-x86_64/bin:${PATH}"

# Install Python dependencies
ADD . /tmp/ark
WORKDIR /tmp/ark
RUN python3 -m pip install --no-cache-dir -r requirements.txt

# Install PyTorch and black
RUN python3 -m pip install --no-cache-dir torch black

# Set PATH
RUN echo PATH="${PATH}" > /etc/environment

Expand Down
2 changes: 1 addition & 1 deletion docker/base-rocm5.6.dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Temporal Dockerfile for building ARK base image for ROCm 5.6

ARG BASE_IMAGE=rocm/dev-ubuntu-20.04:5.6.1-complete
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

LABEL maintainer="ARK"
Expand Down
2 changes: 1 addition & 1 deletion docker/base-x.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=nvidia/cuda:12.1.1-devel-ubuntu20.04
ARG BASE_IMAGE
FROM ${BASE_IMAGE}

LABEL maintainer="ARK"
Expand Down
Loading