Dotnet: Add modelServiceId support to SemanticKernelAgent #5422
+54
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SemanticKernelAgent` class has been updated to include an optional `modelServiceId` parameter, allowing the specification of a service ID for the model.
rysweet
approved these changes
Feb 17, 2025
|
@lokitoth I don't know if ou ported this into agent chat or not but if you did you may want to take this up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5422 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 171 171
Lines 10576 10576
=======================================
Hits 8002 8002
Misses 2574 2574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…class to include an optional `string? modelServiceId` parameter.
…/cedricmendelin/autogen into dotnet-sk-support-keyed-instance
LittleLittleCloud
approved these changes
Feb 24, 2025
DavidLuong98
approved these changes
Feb 24, 2025
|
@cedricmendelin could you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SemanticKernelAgentclass has been updated to include an optionalmodelServiceIdparameter, allowing the specification of a service ID for the model.Why are these changes needed?
Currently,
SemanticKernelAgentuses the parameterless method for resolvingIChatCompletionSerivce. This will fail, when multiple models are registered in the Kernel.To support different models registered in the Kernel, I adopted the resolving of the
IChatCompletionSerivcewithin theSemanticKernelAgentwith an optional parameter. When it is not set, I resolve the default instance, otherwise, I use the optional parameter as a servide id for resolving theIChatCompletionSerivceservice.Related issue number
Checks