fix: Add input validation for participants in BaseGroupChat (#7580)#7581
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: Add input validation for participants in BaseGroupChat (#7580)#7581Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
When output_dir is None, JupyterCodeExecutor creates a temp directory via tempfile.mkdtemp() but never cleans it up in stop(). This leaks a directory per executor lifetime. This fix: - Uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() when output_dir is None - Stores the reference so it gets cleaned up automatically when stop() is called or when the object is destroyed Fixes microsoft#7389
Add clear validation errors for invalid participants input instead of leaking low-level AttributeError/TypeError. This fixes the issue where RoundRobinGroupChat raises raw python errors for invalid inputs like None, strings, or non-Agent objects. Closes: microsoft#7580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR adds clear input validation for the
participantsparameter inBaseGroupChat(and consequentlyRoundRobinGroupChat), addressing issue #7580.Problem
Previously, when invalid inputs were passed to
RoundRobinGroupChat(participants=...):None→TypeError: object of type 'NoneType' has no len()"not a list"→AttributeError: 'str' object has no attribute 'name'[UserProxyAgent(...), "bad"]→AttributeError: 'str' object has no attribute 'name'Solution
Added validation in
BaseGroupChat.__init__to check:participantsis notNoneparticipantscan be converted to a listChatAgentorTeaminstanceNow invalid inputs raise clear error messages:
TypeError: participants must be a non-empty sequence of ChatAgent or Team instances.TypeError: participants must be a non-empty sequence of ChatAgent or Team instances, but found str at index 0.Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof