Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iptables: Add runtime dependency for alternatives. #10822

Closed
wants to merge 1 commit into from
Closed

iptables: Add runtime dependency for alternatives. #10822

wants to merge 1 commit into from

Conversation

Sumynwa
Copy link
Contributor

@Sumynwa Sumynwa commented Oct 23, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Add runtime dependency on alternatives.

Change Log
  • Update Requires in spec file
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@Sumynwa Sumynwa marked this pull request as ready for review October 23, 2024 14:37
@Sumynwa Sumynwa requested a review from a team as a code owner October 23, 2024 14:37
mfrw
mfrw reviewed Oct 24, 2024
View reviewed changes
SPECS/iptables/iptables.spec
@@ -130,6 +132,9 @@ fi
%{_mandir}/man3/*

%changelog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related PR:

@eric-desrochers
Copy link
Contributor

Look like this is fixing the regression for which we revert the commit via PR #10814

In addition to this fix, should you also re-introduce this commit that no longer exist (since it was reverted) ?
882622d

@eric-desrochers
Copy link
Contributor

eric-desrochers commented Nov 4, 2024 •
edited
Loading

Also please ensure to document this PR using the following tmpl for the stable maintainer group to review: https://github.com/microsoft/azurelinux/blob/3.0/.github/pull_request_template.md

@Sumynwa
Copy link
Contributor Author

Sumynwa commented Nov 12, 2024 •
edited
Loading

Created #11027 to reintroduce nftables changes.

@Sumynwa Sumynwa closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw Awaiting requested review from mfrw

Assignees
No one assigned
Labels
Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sumynwa @eric-desrochers @mfrw