Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch: fix CVE-2024-5187 #10946

Merged
merged 4 commits into from
Nov 13, 2024
Merged

pytorch: fix CVE-2024-5187 #10946

merged 4 commits into from
Nov 13, 2024

Conversation

SeanDougherty
Copy link
Contributor

@SeanDougherty SeanDougherty commented Nov 6, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Fixes CVE-2024-5187 (High, 8.8) in pytorch, and removes unnecessary creation of vendor tarball.

Change Log
  • Add patch to address CVE-2024-5187
  • Remove unnecessary double vendoring of the third_party directory. Doubling happens because the contents of the submodule tarball are pulled directly from the original source tarball and then re-uploaded as this "submodule tarball".
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: 669836

@SeanDougherty SeanDougherty requested a review from a team as a code owner November 6, 2024 01:32
@SeanDougherty SeanDougherty changed the base branch from 3.0 to fasttrack/3.0 November 6, 2024 19:15
@SeanDougherty SeanDougherty requested review from a team as code owners November 6, 2024 19:15
@SeanDougherty SeanDougherty changed the base branch from fasttrack/3.0 to 3.0 November 6, 2024 19:15
@SeanDougherty SeanDougherty removed request for a team November 6, 2024 19:17
@SeanDougherty SeanDougherty removed request for a team November 6, 2024 19:17
@SeanDougherty SeanDougherty changed the base branch from 3.0 to fasttrack/3.0 November 6, 2024 19:35
@SeanDougherty
Copy link
Contributor Author

Rebased branch and updated target to fasttrack/3.0

Thank you @rikenm1

rikenm1
rikenm1 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up the Spec.

@jslobodzian jslobodzian merged commit 3c31112 into fasttrack/3.0 Nov 13, 2024
9 checks passed
@jslobodzian jslobodzian deleted the pytorch-cve-2024-5187 branch November 13, 2024 01:07
CBL-Mariner-Bot pushed a commit that referenced this pull request Nov 13, 2024
@SeanDougherty @CBL-Mariner-Bot
pytorch: fix CVE-2024-5187 (#10946)
ccb2358 
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 3c31112)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Nov 13, 2024
Open
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=674515&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbykhovtsev-ms mbykhovtsev-ms mbykhovtsev-ms approved these changes

@rikenm1 rikenm1 rikenm1 approved these changes

@christopherco christopherco christopherco approved these changes

@anphel31 anphel31 anphel31 approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees
No one assigned
Labels
Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SeanDougherty @CBL-Mariner-Bot @jslobodzian @anphel31 @christopherco @rikenm1 @mbykhovtsev-ms