ruby: update to 3.3.5 to resolve CVE-2024-39908 and CVE-2024-49761 #10988
+120
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
force-pushed
the
saulparedes/CVE-2024-39908
branch
3 times, most recently
from
44f08f1
to
4e28408
Compare
|
Failed install test in buddy build but able to install in 3.0 container |
Redent0r
force-pushed
the
saulparedes/CVE-2024-39908
branch
from
4e28408
to
2f89dc3
Compare
jslobodzian
approved these changes
Nov 11, 2024
mbykhovtsev-ms
approved these changes
Nov 11, 2024
Redent0r
force-pushed
the
saulparedes/CVE-2024-39908
branch
from
2f89dc3
to
dda7f8f
Compare
12 tasks
Redent0r
force-pushed
the
saulparedes/CVE-2024-39908
branch
from
dda7f8f
to
26b279c
Compare
jslobodzian
approved these changes
Nov 12, 2024
|
I'm not sure how it failed fast track github PR check to build, but built correctly in https://dev.azure.com/mariner-org/mariner/_build/results?buildId=674310&view=results edit: realized I need to update some rubygem versions, per https://github.com/microsoft/azurelinux/pull/10400/files#diff-4edf04c433f280e43572ad4bc157e9849973a07d14a9dd85e949090f03386010 |
Also remove CVE-2024-41946.patch as it no longer applies as ruby 3.3.5 containers rubygem-rexml 3.3.6, where CVE-2024-41946 is already fixed Signed-off-by: Saul Paredes <[email protected]>
Patch adapted from ruby/rexml@ce59f2e which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761 Needed for rubygem-rexml versions < 3.3.9 Signed-off-by: Saul Paredes <[email protected]>
Patch adapted from ruby/rexml@ce59f2e which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761 Needed for rubygem-rexml versions < 3.3.9 Signed-off-by: Saul Paredes <[email protected]>
Redent0r
force-pushed
the
saulparedes/CVE-2024-39908
branch
from
26b279c
to
ff19fcd
Compare
anphel31
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Upgrade ruby to 3.3.5 to resolve CVE-2024-39908. ruby 3.3.5 contains rubygem-xml version > 3.3.2, which is not affected by CVE-2024-39908 .
Also:
ruby: patch GHSA-2rxp-v6pw-ch6m
rubygem-rexml: patch GHSA-2rxp-v6pw-ch6m
Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology