make install_dependencies work with file dependencies #11054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
In a
containerized-rpmbuild
environment, the functioninstall_dependencies
will install allBuildRequires
dependencies from a spec file. However, it wasn't able to handle file dependencies likeBuildRequires: %{_bindir}/cmp
, which requires looking up the package that provides the file.This change uses
tdnf repoquery
to get the appropriate package.I also added usage of
jq
in that function, so I added it to the list of packages we always install (it's useful anyway), and did a minor refactor of how we do that.Change Log
install_dependencies
to support file dependencies.jq
as a package to always install in the container.Does this affect the toolchain?
NO
Test Methodology