Skip to content

Conversation

@azurelinux-security
Copy link
Contributor

@azurelinux-security azurelinux-security commented Nov 15, 2025

Auto Patch moby-engine for CVE-2025-58183.

Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=983215&view=results

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES/NO

Associated issues
  • N/A
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Nov 15, 2025
@Kanishk-Bansal Kanishk-Bansal marked this pull request as ready for review November 17, 2025 10:49
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner November 17, 2025 10:49
@xordux
Copy link
Contributor

xordux commented Nov 17, 2025

  • Patch applied in logs: Yes
  • Upstream Patch matches: Yes, backport seems correct.
  • Test failure: No

@xordux xordux added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Nov 17, 2025
@0xba1a
Copy link
Contributor

0xba1a commented Nov 19, 2025

  • Patch applied in logs: Yes
  • Upstream Patch matches: Yes, backport seems correct.
  • Test failure: No

@xordux Please check whether the patch fixes the problem logically and not introducing any possible regression and provide signoff.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will verify CVE applicability once. --> As per this, #15098 (review), removing "Request changes". Will leave for above comment to be resolved.

@kgodara912 kgodara912 self-requested a review November 24, 2025 06:27
@xordux
Copy link
Contributor

xordux commented Nov 25, 2025

I signoff this patch. It fixes the problem logically and not introducing any possible regression.

One point that might cause confusion is: “Why doesn’t this CVE patch include the maxSpecialFileSize value?”
The reason is that maxSpecialFileSize is already set by another patch in moby-engine, which you can find here: link to patch

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch matches with upstream reference except test files. Buddy build is successful. LGTM.

@kgodara912 kgodara912 merged commit 763fa41 into microsoft:3.0-dev Nov 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 AI Backport AutoPR-Security Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants