-
Notifications
You must be signed in to change notification settings - Fork 602
Upgrade:perl-FFI-CheckLib to version 0.31 #15144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
Hi @sandeepkarambelkar Please add following packages in buddy build too- |
|
Buddy Build is successful test for perl-FFI-Chacklib have passed but test verification failed because of dependent package-perl-Return-MultiLevel. |
|
3.0-dev build of dependent packages - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=990652&view=results |
|
Verified that package package-perl-Return-MultiLevel test failure is not related to this PR change and it fails on 3.0-dev as well. Ref - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=990652&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6 |
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy Build is successful.
Changes LGTM.
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As such changes are fine. Check if there is any need to publish test package.
|
|
||
|
|
||
| %package tests | ||
| Summary: Tests for %{name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not need test package in our publishing. Please check and keep test package generation only test path if it is not needed for any other package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Upgrade perl-FFI-CheckLib to version 0.31.
Change Log
Does this affect the toolchain?
NO
Test Methodology
-Screenshot for successful local build.-

