For out-of-scope package, do not update its dependencies versions alo…

…ng with its own version (#428)

* scope bump

* Change files

change/beachball-2020-10-21-10-49-12-bump-scoped-pkg.json

@@ -0,0 +1,8 @@
+{
+  "type": "minor",
+  "comment": "For out-of-scope package, do not update its dependencies versions along with its own version.",
+  "packageName": "beachball",
+  "email": "[email protected]",
+  "dependentChangeType": "patch",
+  "date": "2020-10-21T17:49:12.375Z"
+}

src/__e2e__/bump.test.ts

@@ -478,7 +478,7 @@ describe('version bumping', () => {
     expect(changeFiles.length).toBe(1);
   });
 
-  it('should not bump out-of-scope package even if dependency of the package has change', async () => {
+  it('should not bump out-of-scope package and its dependencies even if dependency of the package has change', async () => {
     repositoryFactory = new MonoRepoFactory();
     await repositoryFactory.create();
     const repo = await repositoryFactory.cloneRepository();
@@ -504,7 +504,7 @@ describe('version bumping', () => {
     const packageInfos = getPackageInfos(repo.rootPath);
     expect(packageInfos['foo'].version).toBe('1.0.0');
     expect(packageInfos['bar'].version).toBe('1.3.5');
-    expect(packageInfos['foo'].dependencies?.bar).toBe('^1.3.5');
+    expect(packageInfos['foo'].dependencies?.bar).toBe('^1.3.4');
 
     const changeFiles = getChangeFiles(repo.rootPath);
     expect(changeFiles.length).toBe(0);

src/bump/bumpInPlace.ts

@@ -13,7 +13,7 @@ import { setDependentVersions } from './setDependentVersions';
  */
 export function bumpInPlace(bumpInfo: BumpInfo, options: BeachballOptions) {
   const { bumpDeps } = options;
-  const { packageInfos, packageChangeTypes, modifiedPackages } = bumpInfo;
+  const { packageInfos, scopedPackages, packageChangeTypes, modifiedPackages } = bumpInfo;
   const changes = { ...packageChangeTypes };
   // pass 1: figure out all the change types for all the packages taking into account the bumpDeps option and version groups
   if (bumpDeps) {
@@ -32,7 +32,7 @@ export function bumpInPlace(bumpInfo: BumpInfo, options: BeachballOptions) {
   });
 
   // pass 3: Bump all the dependencies packages
-  const dependentModifiedPackages = setDependentVersions(packageInfos);
+  const dependentModifiedPackages = setDependentVersions(packageInfos, scopedPackages);
   dependentModifiedPackages.forEach(pkg => modifiedPackages.add(pkg));
 
   return bumpInfo;

src/bump/setDependentVersions.ts

@@ -1,9 +1,13 @@
 import { PackageInfos, PackageDeps } from '../types/PackageInfo';
 import { bumpMinSemverRange } from './bumpMinSemverRange';
 
-export function setDependentVersions(packageInfos: PackageInfos) {
+export function setDependentVersions(packageInfos: PackageInfos, scopedPackages: Set<string>) {
   const modifiedPackages = new Set<string>();
   Object.keys(packageInfos).forEach(pkgName => {
+    if (!scopedPackages.has(pkgName)) {
+      return;
+    }
+
     const info = packageInfos[pkgName];
     ['dependencies', 'devDependencies', 'peerDependencies'].forEach(depKind => {
       const deps: PackageDeps | undefined = (info as any)[depKind];

src/commands/canary.ts

@@ -27,7 +27,7 @@ export async function canary(options: BeachballOptions) {
     bumpInfo.packageInfos[pkg].version = newVersion;
   }
 
-  setDependentVersions(bumpInfo.packageInfos);
+  setDependentVersions(bumpInfo.packageInfos, bumpInfo.scopedPackages);
 
   await performBump(bumpInfo, options);
 

src/commands/sync.ts

@@ -34,7 +34,7 @@ export async function sync(options: BeachballOptions) {
     }
   }
 
-  const dependentModifiedPackages = setDependentVersions(packageInfos);
+  const dependentModifiedPackages = setDependentVersions(packageInfos, scopedPackages);
   dependentModifiedPackages.forEach(pkg => modifiedPackages.add(pkg));
 
   writePackageJson(modifiedPackages, packageInfos);