Repository navigation
Updates to slack-adapter - #1559
Conversation
|
I noticed in my tests that channel_id of a ConversationReference object (which is always "slack") is not the same as the channel ID that chat.delete API requires. |
|
Omid Jafari (@omid-jf) Thanks! I'll take a look and apply the fixes. |
…rosoft/botbuilder-python into trboehre/slackadapter-update
| super().__init__(on_turn_error) | ||
| self.slack_client = client | ||
| self.slack_logged_in = False | ||
| self.options = options if options else SlackAdapterOptions() |
There was a problem hiding this comment.
This is nitpicking but this could be changed to:
self.options = options or SlackAdapterOptions
Axel Suárez (axelsrz)
left a comment
There was a problem hiding this comment.
Approved with comments
Fixes #1548
There have been some some updates to the DotNet slack-adapter, and this PR includes most of those changes.