Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump macOS version and fix iOS build #1326

Merged
merged 64 commits into from
Feb 10, 2025
Merged

Bump macOS version and fix iOS build #1326

merged 64 commits into from
Feb 10, 2025

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Feb 6, 2025 •
edited
Loading

This is a continuation from the PR #1299.

lalitb and others added 30 commits September 5, 2024 07:16
@lalitb
bump macos version
1048418
@lalitb
Merge branch 'main' into bump-macos-12-14
742fea4
@lalitb
incorrect version
10a2697
@lalitb
check install prefix access
cb4d84d
@mkoscumb
Merge branch 'main' into bump-macos-12-14
c89e0d9
@ThomsonTan
Merge branch 'main' into bump-macos-12-14
fbf4c6a
@lalitb
Merge branch 'main' into bump-macos-12-14
262a4e1
@lalitb
fix the cmake to not exit if the write test fail
db048cf
@lalitb
macos12 is deprecated. switch to macos13 and macos15
4e7e8cc
@lalitb
try to gracefully fail for write
7dac26f
@lalitb
more cleaner check
0c7ff51
@lalitb
update ci yaml
c058ef3
@lalitb
update the simulators
a500fcb
@lalitb
use iphone 16 as simulator
72bf84a
@ThomsonTan
Merge branch 'main' into bump-macos-12-14
d1e8284
@ThomsonTan
Add debug code to build-gtest.sh
2c4f2ba
@ThomsonTan
Add more log
3c7d85b
@ThomsonTan
Update checkout action
da2986b
@ThomsonTan
Fix checkout submodules
200632a
@ThomsonTan
Fix build variable name
f6bd624
@ThomsonTan
Add more log
ff8f3ad
@ThomsonTan
Set architecture
2c5d740
@ThomsonTan
Set one more flag
4729037
@ThomsonTan
Dump the arch of gtest library
655fa47
@ThomsonTan
Add optin for lipo
c7c5b83
@ThomsonTan
Log test target
7a1b68e
@ThomsonTan
Add build entry/exit log
cc036d2
@ThomsonTan
Build for active arch only
32326b8
@ThomsonTan
Log arch
9e0ec42
@ThomsonTan
Check variable cache
0e81432
lalitb
lalitb reviewed Feb 10, 2025
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
lalitb
lalitb approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing the CI. Good work :)

@ThomsonTan ThomsonTan changed the title Experimental iOS build Bump macOS version and fix iOS build Feb 10, 2025
@ThomsonTan ThomsonTan marked this pull request as ready for review February 10, 2025 17:51
@ThomsonTan ThomsonTan requested a review from a team as a code owner February 10, 2025 17:51
@ThomsonTan ThomsonTan merged commit 3506286 into main Feb 10, 2025
27 of 28 checks passed
@ThomsonTan ThomsonTan deleted the ios_build_debug branch February 10, 2025 17:51
@ThomsonTan ThomsonTan mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomsonTan @lalitb @mkoscumb