-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support isolated component build #1204
Draft
jason-ha
wants to merge
20
commits into
microsoft:master
Choose a base branch
from
jason-ha:isolated_components_on_narrow_strings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support isolated component build #1204
jason-ha
wants to merge
20
commits into
microsoft:master
from
jason-ha:isolated_components_on_narrow_strings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
independent of UNICODE vs MBCS setting Set CPPREST_FORCE_NARROW_STRINGS=ON to enable. Simplistic cleanup throughout project is not possible as some Windows APIs require utf16 such as HTTPSPolicyCallbackData in http_client_winhttp.cpp. HTTP related code is not completely updated so a full package may not be produced, though settings exist to have a clean build. Use: -DCPPREST_FORCE_NARROW_STRING=ON -DCPPREST_EXCLUDE_WEBSOCKETS=ON -DCPPREST_HTTP_LISTENER_IMPL=none -DBUILD_SAMPLES=OFF
…omponents like just json support extractions from asyncrt_utils.h: base64_utils.h (to/form base64) memory_utils.h (details::make_unique) string_utils.cpp (string utils) asyncrt_utils retains error, date-time, and nounce utils
…braries fixup includes from not using a common precompiled header - separate windows header config to be usable outside of pch
- missing headers (stl/config dependent) - correct install for static lib builds also add isolation build to Ubuntu Vcpkg and break up Ubuntu Apt
- more explicit includes +cmake comment tweak
…afx.h's include of everything The exact dependency was not reviewed when making this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for feature request #68
Add build option CPPREST_ISOLATE_COMPONENTS to build cpprest sub-components as individual libraries. They are not installed, but are tested individually and can be directly targeted as external CMake projects.
Doing so allows consumption of smaller code and use of options such as CPPREST_FORCE_NARROW_STRINGS that are not supported across all parts of cpprest.
This PR also includes changes from PR 1199
To see changes with that PR as baseline review jason-ha#1.