fix format-truncation on 64bit #1462
Conversation
GCC 10.x rightfully complains about out-of-bounds snprintf operation on 64bit systems, where size_t could be 64bit sized. Cast bytes_read down to 32bit and printf it without specifying input format Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann
force-pushed
the
gcc10-64bit
branch
from
6c635f9 to
76dded3
Compare
|
@BrandonStaab anything I can do to get this merged? |
|
@ALL is there anything I can do to get this here merged? |
|
Merge request helped me. All autotests passed. |
|
Any chances to see this merged and released? |
|
Trying to build on Arch via AUR and getting errors. Building with this PR fixes all issues...please merge and release |
|
Soon this PR will have its first anniversary - is there the slightest chance of getting it at least merged - I mean to me this is a critical bug, as without it even compilation is broken |
|
@barcharcraz, can you give us some feedback on this as everyone using a modern compiler gets a compilation error without this PR |
|
2 years passed, looks we have to carry this manually with ourselves. |
Maybe time to drop this PR to increase the pressure 👿 😁 |
|
@barcharcraz, as the other former maintainers are not responding to the merge this code change here, would you be willing to unblock the compilation for anyone with having gcc 10+? |
GCC 10.x rightfully complains about out-of-bounds snprintf operation
on 64bit systems, where size_t could be 64bit sized.
Cast bytes_read down to 32bit and printf it without specifying input
format
Fixes #1461
Signed-off-by: Konrad Weihmann [email protected]