Show low-level error message for OpenSSL errors #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such errors may contain valuable information and we shouldn't just lose it completely as happened before.
jemmy512
reviewed
Dec 12, 2020
| if (ec.category() == boost::asio::error::ssl_category || | ||
| ec.category() == boost::asio::ssl::error::stream_category) | ||
| { | ||
| message += " ("; |
There was a problem hiding this comment.
message += " (" + ec.message() + ")";seems more clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such errors may contain valuable information and we shouldn't just lose
it completely as happened before.
This is as simple as it gets, but allows to see messages like "Error in SSL handshake (certificate verify failed)" instead of just the part before the parentheses, which can be pretty invaluable when trying to diagnose a problem (in this case due to a proxy mounting a MitM attack on the connection...). Perhaps the error message should be included for other errors too, but it definitely should be done for those ones.