Docker labels #337
Merged
Docker labels #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pod fails to pull its container image, it stays in Pending phase with ImagePullBackOff status. Previously this would wait the full 2-hour timeout. Now we detect persistent ImagePullBackOff and fail after a configurable timeout (default: 10 minutes). Key changes: - Add image_pull_backoff_timeout parameter (default 600s, 0 to disable) - Add _check_image_pull_status() method to detect ImagePullBackOff - Track backoff duration and fail if it persists past threshold - Reset timer if backoff resolves (allows transient failures to recover) The 10-minute default handles transient issues (registry rate limiting, network blips) while catching true failures much faster than before. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 34642c7.
MarcCote
approved these changes
Jan 23, 2026
Update pre-commit config to use black 26.1.0 to match CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of container labels for Docker terminals in the
debug_gymproject. The main improvement is the addition of support for passingextra_labelsto Docker containers, similar to existing support for Kubernetes terminals. This allows for better identification and management of containers, especially during cleanup. The changes also include corresponding updates to the codebase and new tests to ensure correct behavior.Docker Terminal Label Support:
extra_labelsparameter to theDockerTerminalclass, storing it as an instance variable and documenting its purpose in the docstring. [1] [2] [3]setup_containermethod inDockerTerminalto always include anapp=debug-gymlabel and merge any providedextra_labelswhen creating containers.Terminal Selection Logic:
select_terminalfunction to passextra_labelsto bothKubernetesTerminalandDockerTerminal, ensuring consistent label support across terminal types.Testing:
test_select_terminal_docker_extra_labels, to verify thatextra_labelsare correctly passed to theDockerTerminaland that the original config remains unmodified.