This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Exclude download-git-repo from forbidden words
#349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package already exists on npm, so if I understand the matter correctly, it should be allowed here, too: https://www.npmjs.com/package/download-git-repo Complements ad7eb60. Required for DefinitelyTyped/DefinitelyTyped#56874.
sandersn
suggested changes
Oct 29, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Unfortunately, no. =( Even though download-git-repo is allowed on npm because it's old, DT is not allowed to publish @types/download-git-repo, because it will be a new package.
Author
|
Ah, I see, so what does this mean for my PR to DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#56874) Do I have to submit it under a different name? |
LinqLover
added a commit
to LinqLover/dtslint
that referenced
this pull request
Dec 22, 2021
See also microsoft#349 and microsoft#350. As soon as an official decision for this issue exists, that should be referenced in the docs as well.
This was referenced Dec 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package already exists on npm, so if I understand the matter correctly, it should be allowed here, too:
https://www.npmjs.com/package/download-git-repo
Complements ad7eb60. Required for DefinitelyTyped/DefinitelyTyped#56874.