Speedup ebpf_handle_table_terminate by avoiding acquire/release of lock #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
mtfriesen
previously approved these changes
Jun 4, 2024
|
Before: After: |
Wow - is this a unit test for this handle table specifically, or all unit tests are accelerated by this? |
This affects every single unit test, adding a few hundred ms delay to it. It ends up modifying thread priority and affinity 1024*2 times per each test, which adds up fast. |
mikeagun
previously approved these changes
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
dthaler
previously approved these changes
Jun 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@Alan-Jowett please check unit test failure that caused this to be removed from the merge queue |
Signed-off-by: Alan Jowett (from Dev Box) <[email protected]>
Alan-Jowett
force-pushed
the
speedup_handle_table
branch
from
5737df8
to
155519a
Compare
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
dismissed stale reviews from dthaler, mtfriesen, and mikeagun
via
5c32e97
dthaler
approved these changes
Jun 22, 2024
mikeagun
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace calls to ebpf_handle_close, which acquired and released the handle table lock each time an emulated handle was closed, with a lock acquire and close on each valid handle.
Testing
CI/CD
Documentation
No.
Installation
No.