-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TraceLoggingBinary for map find, update and delete. #3781
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3781 +/- ##
==========================================
+ Coverage 83.78% 86.57% +2.79%
==========================================
Files 143 150 +7
Lines 27297 28955 +1658
==========================================
+ Hits 22870 25068 +2198
+ Misses 4427 3887 -540 ☔ View full report in Codecov by Sentry. |
…or-windows into shpalan/map-find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but see nit
Description
This PR contains
#define _EBPF_LOG_MESSAGE_BINARY(trace_level, keyword, message, type, name, data, data_size)
This tracing aims to instrument the map invocations and tail calls in the drivers.
Testing
_Do any existing tests cover this change? N/A
Are new tests needed? No, as this is a trace log.
Logs:
[0]0004.15E8::2024/09/17-18:08:02.977888400 [EbpfForWindowsProvider]{"Message":"Tail call program","string":"xxxx","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2024-09-18T01:08:02.9778884Z","cpu":0,"pid":4,"tid":5608,"channel":11,"level":5,"keywords":"0x80"}}
[0]0004.15E8::2024/09/17-18:08:02.977892100 [EbpfForWindowsProvider]{"Message":"Tail call program","string":"xxxx","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2024-09-18T01:08:02.9778921Z","cpu":0,"pid":4,"tid":5608,"channel":11,"level":5,"keywords":"0x80"}}
[0]0004.15E8::2024/09/17-18:08:02.977894000 [EbpfForWindowsProvider]{"Message":"Map update","string":"xxxx","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2024-09-18T01:08:02.9778940Z","cpu":0,"pid":4,"tid":5608,"channel":11,"level":5,"keywords":"0x40"}}
[0]0004.15E8::2024/09/17-18:08:02.977894700 [EbpfForWindowsProvider]{"Message":"Key","(data).Length":12,"(data)":"0x0A0101030403020100010600","meta":
Note: Program name and map name are masked with xxxx in the logs.
Documentation
_Is there any documentation impact for this change? No
Installation
_Is there any installer impact for this change? No