Code cleanup. #4184
Open
Code cleanup. #4184
+5
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
matthewige and
mtfriesen
as code owners
dthaler
added
the
cleanup
dthaler
previously approved these changes
Feb 10, 2025
Alan-Jowett
previously approved these changes
Feb 10, 2025
shankarseal
dismissed stale reviews from Alan-Jowett and dthaler
via
f60af82
shankarseal
force-pushed
the
fix_nmr_ver
branch
from
f60af82 to
1a11b96
Compare
Alan-Jowett
approved these changes
Feb 12, 2025
dthaler
approved these changes
Feb 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
A couple of code cleanups.
Per MSDN, the
Versionfields of the NPI client and provider characteristics structure should be set to 0. In a few places in the code this was not followed.Per the ebpfExtensions.md
Yet the unit test had a test case that expected the opposite. I have removed the test case.
Testing
Do any existing tests cover this change? Are new tests needed?
Existing tests are sufficient.
Documentation
Is there any documentation impact for this change?
No.
Installation
Is there any installer impact for this change?
No.