Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyExportJobWorker #4750

Open
brendankowitz opened this issue Dec 10, 2024 · 0 comments
Open

Remove LegacyExportJobWorker #4750

brendankowitz opened this issue Dec 10, 2024 · 0 comments
Assignees
@paorodma-ms
Labels
Enhancement-Refactor Refactor on existing functionality. .NET Pull requests that update .net code Up for grabs The issue require minimal context and is well-suited for new contributors.

Comments

@brendankowitz
Copy link
Member

brendankowitz commented Dec 10, 2024 •
edited
Loading

User story
As a Developer, I want to remove LegacyExportJobWorker and related config, settings and tests so that our code is more maintainable.

Acceptance criteria

  1. QueueClient Export jobs is on as the default export worker
  2. All legacy code is removed

Also see
@brendankowitz brendankowitz added Up for grabs The issue require minimal context and is well-suited for new contributors. Enhancement-Refactor Refactor on existing functionality. .NET Pull requests that update .net code labels Dec 10, 2024
paorodma-ms added a commit that referenced this issue Feb 20, 2025
@paorodma-ms
Remove LegacyExportJobWorker #4750
3919198
@paorodma-ms paorodma-ms self-assigned this Feb 21, 2025
@paorodma-ms paorodma-ms mentioned this issue Feb 24, 2025
Merged
1 task
paorodma-ms added a commit that referenced this issue Mar 3, 2025
@paorodma-ms
Remove legacy export job worker (#4838)
9f0655e 
* Remove LegacyExportJobWorker #4750

* Remove UseQueueClientJobs configuration since it is the default now, no other possibility. Remove unused variables from CosmosFhirOperationDataStore

* Remove classes and stored procedures from Cosmos DB related to LegacyExportJob. Modified unit test in CosmosDBInitializationTests to appropriately check for all incoming list of sp's

* Readded necessary legacy code to be able to query a legacy export job.

* Remove commented code from test

* Add schema version 86, removing unused table ExportJob
@paorodma-ms paorodma-ms mentioned this issue Mar 12, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paorodma-ms paorodma-ms

Labels
Enhancement-Refactor Refactor on existing functionality. .NET Pull requests that update .net code Up for grabs The issue require minimal context and is well-suited for new contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendankowitz @paorodma-ms