Remove legacy export job worker #4838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no other possibility. Remove unused variables from CosmosFhirOperationDataStore
…ExportJob. Modified unit test in CosmosDBInitializationTests to appropriately check for all incoming list of sp's
Comment on lines
-114
to
-120
| if (IsLegacyJob(id)) | ||
| { | ||
| // try old job records | ||
| var oldJobs = (ILegacyExportOperationDataStore)this; | ||
| return await oldJobs.GetLegacyExportJobByIdAsync(id, cancellationToken); | ||
| } | ||
|
|
There was a problem hiding this comment.
@LTA-Thinking FYI, just want to confirm if you think this should be ok to delete? Its been a long while since old jobs were created
| // try old job records | ||
| var oldJobs = (ILegacyExportOperationDataStore)this; | ||
| return await oldJobs.CreateLegacyExportJobAsync(jobRecord, cancellationToken); | ||
| return await base.CreateExportJobAsync(jobRecord, cancellationToken); |
There was a problem hiding this comment.
If we are only calling the base, we shouldn't need the override at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all classes, stored procedures and configurations related to Legacy export job worker.
Related issues
Addresses issue #4750.
Testing
Unit tests were executed.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)