Improve HTML validation #3192
Open
Improve HTML validation #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
added
Bug
Comment on lines
-293
to
-299
| if (string.Equals("src", attr.Name, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| if (!Src.Any(x => attr.Value.StartsWith(x, StringComparison.OrdinalIgnoreCase))) | ||
| { | ||
| onInvalidAttr(element, attr); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add a few examples to the tests of what this now supports? (i.e. the IG image example) Are there any negative test cases we should add?
There was a problem hiding this comment.
I don't think there are any negatives to add. @michael-wilson-au added a negative test as part of the first PR, but my change only removes a restriction. I'll add some examples of what is supported.
fhibf
approved these changes
Mar 31, 2023
LTA-Thinking
added
the
KI-Breaking
|
Waiting for customer communication to be planned before merging. As this is a breaking change due to the more strict validation we want to alert customers first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves HTML validation with change from #3101 and removing src validation which was preventing most Structure Definitions from being loaded.
Related issues
Addresses #3100
Testing
New/existing tests
FHIR Team Checklist
Semver Change (docs)
Patch