[Docker] AppInsights Workpace and non-private tag #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhibf
changed the title
fhibf
added
Enhancement
LTA-Thinking
approved these changes
Jan 22, 2024
fhibf
changed the title
fhibf
changed the title
fhibf
changed the title
| "kind": "web", | ||
| "tags": { | ||
| "[concat('hidden-link:', variables('appServiceResourceId'))]": "Resource", | ||
| "displayName": "AppInsightsComponent", | ||
| "FhirServerSolution": "[parameters('solutionType')]" | ||
| "FhirServerSolution": "[parameters('solutionType')]", | ||
| "Privacy.Asset.NonPersonal": "" |
There was a problem hiding this comment.
When this script is executed, it creates App Insights resources that can trigger S360 alerts in our subscriptions.
To minimize the number of S360 alerts I thought about adding this tag during the creation of these App Insights.
There was a problem hiding this comment.
I don't think this tag is correct for all OSS deployments. We should check w/ Joyce, but my understanding is If you deploy a test OSS solution and you login with your IP address, upn, etc that is still personal data even if it's only employee data.
I would recommend exposing an "additionalTags" variable that is an object and combining it with this tag object. I've seen this done in the past
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in the docker template:
Testing
Ran the script manually I was able to create the workspace and assign the non-personal tag as expected.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)