Fix: Check if bundle resource type is valid #3715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiisnn
commented
Feb 14, 2024
...lth.Fhir.Shared.Api/Features/Filters/FhirRequestContextRouteDataPopulatingFilterAttribute.cs
Outdated
Show resolved
Hide resolved
abiisnn
commented
Feb 14, 2024
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BundleTransactionTests.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BundleTransactionTests.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandler.cs
Fixed
Show fixed
Hide fixed
abiisnn
changed the title
abiisnn
changed the title
abiisnn
commented
Feb 22, 2024
| @@ -195,5 +199,16 @@ public void CheckElementsParameter(HttpContext httpContext) | |||
| throw new BadRequestException(string.Format(Api.Resources.InvalidElementsParameter, elementsParameterValue)); | |||
| } | |||
| } | |||
|
|
|||
| public void CheckIfBundleTypeIsInvalid(HttpContext httpContext) | |||
There was a problem hiding this comment.
Let me know if this check should be in a different place.
abiisnn
changed the title
Comment on lines
+91
to
+94
| fhirRequestContext.BundleIssues.Add(new OperationOutcomeIssue( | ||
| OperationOutcomeConstants.IssueSeverity.Error, | ||
| OperationOutcomeConstants.IssueType.Exception, | ||
| ex.Message)); |
There was a problem hiding this comment.
Since this isn't a recoverable error I don't think this belongs here. BundleIssues are mainly used for reporting issues during Search requests.
...why not just throw BadRequestException here?
There was a problem hiding this comment.
For some reason if I throw a BadRequest, it does return a 500 error instead of 400 as we want, so I added this as a work around but open to feedback, I will ask Fernando since he has more context!
abiisnn
force-pushed
the
abigailn/add_try_catch_to_bundle
branch
from
fc66020 to
45b68e4
Compare
abiisnn
force-pushed
the
abigailn/add_try_catch_to_bundle
branch
from
45b68e4 to
3e4b22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When a customer sends a bundle with invalid "type", currently, we receive a 500 Internal Server Error which is incorrect.
Description
Adds validation and return BadRequest when an invalid "type" is received.
Related issues
Addresses [AB#114755].
Testing
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)