-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import bundle #3720
Open
SergeyGaluzo
wants to merge
55
commits into
main
Choose a base branch
from
users/sergal/importbundles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Import bundle #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Fixed
Show fixed
Hide fixed
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Enhancement
Enhancement on existing functionality.
Schema Version unchanged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid confusion...
Currently the only API to ingest the set of resources in real time is to POST Bundle. This API has performance and stability issues, which prompted this new work.
My goal was to extend efficient $import logic to real time calls. We should not, at least now, add any extra logic beyond $import, which might have performance impact.
$import uses ndjson as input format. Very efficient. Hence new endpoint should use this format. There is a demand, for customer convenience, support bundle format, so it was enabled too. By no means, this endpoint is a replacement of current generic bundles processing logic.
We should avoid inheriting any complexity allowed by generic bundle format. For example, $import logic (so new endpoint logic) requires resource id. We should avoid attempts to extend functionality by enabling identity search to identify resource. Maybe in future, but not now.
To avoid confusion (added because of bundle format) about what functionality is supported, I suggest refraining from using bundle in endpoint name. I suggest clarifying intent in the documentation.
This endpoint will process batch in a single database call, hence it inherently equivalent to the transaction bundle. It also either PUTs all input resources or none. This makes output response trivial (no need to have complex output logic generic bundles have).
When using bundle format, it would be nice to ignore all bundle components except Resource. We should be clear about it in the documentation. BTW I am not sure that we need to make documentation change now, we can wait till first customer provides feedback.
https://microsofthealth.visualstudio.com/Health/_workitems/edit/117904