Skip to content

ARG query fixes #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025
Merged

ARG query fixes #1549

merged 3 commits into from
May 1, 2025

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Apr 29, 2025

🛠️ Description

Fix duplicate resource ID bug in PBI
Fixes #1541, #1499, #1154

Reduce data size for the NSG query
Fixes #1540

Disabled the PolicyDefinitions query
Fixes #1539, #1496

Remove VMs page from Workload optimization report
Fixes #1499

Handle when there are no results across all ARG queries (so they don't fail refresh)
Fixes #1550

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-04 - April milestone Apr 29, 2025
@flanakin flanakin enabled auto-merge (squash) April 29, 2025 11:01
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 29, 2025
@flanakin flanakin added the Tool: Power BI Power BI reports label Apr 30, 2025
@flanakin flanakin disabled auto-merge April 30, 2025 15:40
@flanakin flanakin merged commit 48942db into dev May 1, 2025
2 checks passed
@flanakin flanakin deleted the flanakin/dev/pbi-argqueries branch May 1, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment