-
Notifications
You must be signed in to change notification settings - Fork 421
[dev-v5] TreeView component v5 #3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-v5
Are you sure you want to change the base?
[dev-v5] TreeView component v5 #3642
Conversation
@vnbaaij i am pretty stuck on this, i haven't been able to figure out on how to bind the onselectedchanged events to the component. It only works for me locally when i add the cdn script to the app.razor, then all bindings work like they should. Should someone else take over? |
I haven't had time to look at this yet. Had issues with getting the pure web component running as well. |
# Conflicts: # src/Core.Scripts/src/FluentUICustomEvents.ts # src/Core.Scripts/src/Startup.ts
Okay, i tried again today but i still can't figure out why the events are not getting registered. When i include the CDN script with the same package version, every event gets nicely added, but the binding to blazor is not working yet (so the onselectedchange event is not working). I am not sure what i am missing! |
I will work on that. But probably creating another PR and using a part of your code. Agree? |
Totally! Can you tag me in the PR, eager to know how this is fixed to learn! |
I started this PR #3802 |
Pull Request
📖 Description
Just me trying to help out with the tree view component. Currently a bit stuck because using the installed web components doesnt make my component work. If i add the CDN style import, it does work. Not entirely sure how to fix it.
Note, most code is simply taken over from the v4 version, as most 'logic' seemed to be the same to the v5 version apart from some more icon slots being added for the fluent-tree-item components and having some more parameters for size and appearance.
📑 Test Plan
✅ Checklist
General
Not complete yet at all!
ted the Unit Tests for an existing component