[InputFile] Remove .ToArray as it is not necessary

[MarvinKlein1508]

Pull Request

📖 Description

This PR removes the ToArray call for the OnCompleted event callback which is not necessary. This saves a few allocations for the copied array.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

• I have added tests for my changes.
• I have tested my changes.
• I have updated the project documentation to reflect my changes.
• I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

• I have added a new component
• I have added Unit Tests for my new component
• I have modified an existing component
• I have validated the Unit Tests for an existing component

⏭ Next Steps

[Tyme-Bleyaert]

Is it not because we want to send a decoupled snapshot of the list?

[MarvinKlein1508]

This could be a reason. But I don't believe that nobody is going to manually cast the IEnumerable<T> into a List<T> and appends or remove items to it. I cannot think of any good reason why someone even should try to do this.

But this is up for the maintainers to decide. I just noticed it while debugging on another issue! :)

[dvoituron]

Actually, I think it's better to keep the ToArray to ensure this decoupling.
It has small impact on performance and avoids potential problems that a user might encounter when manipulating this list in OnCompleted`` . Although I can't immediately think of a practical example of a problem :-)

[dvoituron]

Why change something that works? 🤪

[vnbaaij]

Closing this one on account of "if it ain't broke, dont fix it'...