fix bug to use model context length - #1070
Open
Selena Yang (selenayang888) wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot started reviewing on behalf of
Selena Yang (selenayang888)
September 3, 2026 01:30
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the reported configuration semantics and includes appropriate regression coverage.
Pull request overview
Fixes context-budget validation to use the model’s actual context window while retaining legacy configuration support.
Changes:
- Prioritizes
model.context_lengthoversearch.max_length. - Adds precedence and fallback tests.
- Updates API documentation and error messaging.
File summaries
| File | Description |
|---|---|
search_options.cc |
Corrects context-length resolution. |
search_options.h |
Documents the updated behavior. |
search_options_test.cc |
Tests precedence and legacy fallback. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1067.
Request validation incorrectly used search.max_length as the model’s total context limit. Some models, including Gemma, define a generation default of 4,096 while supporting a context length of 131,072.