Enable fast commit by default + doc updates (#440)

* update docs * Enable fast commit by default * remove manual commitAOF from cluster test * update * update --------- Co-authored-by: Vasileios Zois <[email protected]>
microsoft · Jun 5, 2024 · 9f8e6ad · 9f8e6ad
1 parent f378be3
commit 9f8e6ad
Show file tree

Hide file tree

Showing 7 changed files with 161 additions and 309 deletions.
diff --git a/libs/host/defaults.conf b/libs/host/defaults.conf
@@ -222,7 +222,7 @@
 	"CheckpointThrottleFlushDelayMs" : 0,
 
 	/* Use FastCommit when writing AOF. */
-	"EnableFastCommit" : false,
+	"EnableFastCommit" : true,
 
 	/* Throttle FastCommit to write metadata once every K commits. */
 	"FastCommitThrottleFreq" : 1000,

diff --git a/libs/server/Servers/GarnetServerOptions.cs b/libs/server/Servers/GarnetServerOptions.cs
@@ -229,7 +229,7 @@ public class GarnetServerOptions : ServerOptions
         /// <summary>
         /// Enable FastCommit mode for TsavoriteLog
         /// </summary>
-        public bool EnableFastCommit = false;
+        public bool EnableFastCommit = true;
 
         /// <summary>
         /// Throttle FastCommit to write metadata once every K commits

diff --git a/test/Garnet.test.cluster/ClusterReplicationTests.cs b/test/Garnet.test.cluster/ClusterReplicationTests.cs
@@ -175,7 +175,6 @@ public void ClusterSRNoCheckpointRestartSecondary([Values] bool performRMW, [Val
             context.ValidateKVCollectionAgainstReplica(ref context.kvPairs, 1);
 
             // Shutdown secondary
-            context.nodes[1].Store.CommitAOF(true);
             context.nodes[1].Dispose(false);
 
             Thread.Sleep(TimeSpan.FromSeconds(2));
@@ -250,7 +249,6 @@ public void ClusterSRPrimaryCheckpoint([Values] bool performRMW, [Values] bool d
             context.clusterTestUtils.WaitCheckpoint(1, replicaLastSaveTime, logger: context.logger);
 
             // Shutdown secondary
-            context.nodes[1].Store.CommitAOF(true);
             context.nodes[1].Dispose(false);
             Thread.Sleep(TimeSpan.FromSeconds(2));
 

diff --git a/test/Garnet.test.cluster/ClusterTestContext.cs b/test/Garnet.test.cluster/ClusterTestContext.cs
@@ -98,7 +98,7 @@ public void CreateInstances(
             int CommitFrequencyMs = 0,
             bool DisableStorageTier = false,
             bool EnableIncrementalSnapshots = false,
-            bool FastCommit = false,
+            bool FastCommit = true,
             int timeout = -1,
             bool useTLS = false,
             bool useAcl = false,
@@ -182,7 +182,7 @@ public GarnetServer CreateInstance(
             int CommitFrequencyMs = 0,
             bool DisableStorageTier = false,
             bool EnableIncrementalSnapshots = false,
-            bool FastCommit = false,
+            bool FastCommit = true,
             int timeout = -1,
             int gossipDelay = 5,
             bool useTLS = false,

diff --git a/test/Garnet.test/TestUtils.cs b/test/Garnet.test/TestUtils.cs
@@ -313,7 +313,7 @@ public static GarnetServer[] CreateGarnetCluster(
             int CommitFrequencyMs = 0,
             bool DisableStorageTier = false,
             bool EnableIncrementalSnapshots = false,
-            bool FastCommit = false,
+            bool FastCommit = true,
             string authUsername = null,
             string authPassword = null,
             bool useAcl = false, // NOTE: Temporary until ACL is enforced as default
@@ -397,7 +397,7 @@ public static GarnetServerOptions GetGarnetServerOptions(
             int CommitFrequencyMs = 0,
             bool DisableStorageTier = false,
             bool EnableIncrementalSnapshots = false,
-            bool FastCommit = false,
+            bool FastCommit = true,
             string authUsername = null,
             string authPassword = null,
             bool useAcl = false, // NOTE: Temporary until ACL is enforced as default

diff --git a/website/docs/welcome/about-us.md b/website/docs/welcome/about-us.md
@@ -11,15 +11,13 @@ Check out our blog post [here](/blog/brief-history) for more details on our hist
 ## Contributors
 
 Core Team:
-* Badrish Chandramouli, Vasileios Zois, Ted Hart, Yoganand Rajasekaran, Tal Zaccai, Lukas Maas, Darren Gehring, Irina Spiridonova.
+* Badrish Chandramouli, Vasileios Zois, Ted Hart, Yoganand Rajasekaran, Tal Zaccai, Lukas Maas, Darren Gehring.
 * Email: garnetteam AT microsoft.com
 
 Project Partners:
 * Alan Yang, Pradeep Yadav, Alex Dubinkov, Venugopal Latchupatulla.
 * Knut Magne Risvik, Sarah Williamson, Narayanan Subramanian, Saurabh Singh, Padmanabh Gupta.
-* Kevin Montrose, Matt Tremblay.
-* Open-source contributors to [Garnet](https://github.com/microsoft/garnet/contributors).
+* Kevin Montrose, Matt Tremblay, Marc Gravell.
+* Paulus Pärssinen.
+* Open-source and prior contributors to the [Garnet](https://github.com/microsoft/garnet/contributors) and [FASTER](https://github.com/microsoft/FASTER/contributors) projects.
 
-Prior Contributors:
-* Sajjad Rahnama, Gabriela Martinez Sanchez.
-* Open-source contributors to [FASTER](https://github.com/microsoft/FASTER/contributors).