Dev Guide for Cluster Sharding/Migration #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Great to have more docs! It's gonna be tought to keep the quoted code snippets in sync though? |
lmaas
suggested changes
May 7, 2024
lmaas
suggested changes
May 8, 2024
Good point. I would argue that some fundamental parts of the code base will not change as frequently as others. That being said, we can probably add some pseudocode where needed instead of actual code. We might need to go through the other sections of the dev guide to make sure this convention is followed. |
vazois
force-pushed
the
vazois/dev-cluster
branch
3 times, most recently
from
6ccdd8e
to
94e031d
Compare
|
I updated the website to add a reference to github permalink. This way the dev guide is more resilient to code changes. |
vazois
force-pushed
the
vazois/dev-cluster
branch
from
796f04b
to
533f877
Compare
vazois
force-pushed
the
vazois/dev-cluster
branch
from
533f877
to
9ba9306
Compare
TalZaccai
approved these changes
May 21, 2024
lmaas
approved these changes
May 21, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* added separate sidebar section for cluster dev guide * completed sharding section of dev guide * first iteration of dev guide slot migration * complete migration dev guide * addressing comments * nit * misc cleanup * some rewriting and cleanup * another pass for sharding * cleanup overview.md in cluste dev guide * add code snippet reference to github code * add yarn lock --------- Co-authored-by: Tal Zaccai <[email protected]> Co-authored-by: Lukas Maas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer guide webpage containing information about sharding and migration.