Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various API bugfixes #417

Merged
merged 8 commits into from
May 29, 2024
Merged

Various API bugfixes #417

merged 8 commits into from
May 29, 2024

Conversation

TalZaccai
Copy link
Contributor

@TalZaccai TalZaccai commented May 23, 2024 •
edited
Loading

  • TTL / PTTL should return -2 when key does not exist
  • MODULE * should return an unknown command error since not yet implemented
  • GETRANGE with non-existing key should return an empty string
  • SRANDMEMBER with non-existing key and count specified should return an empty array
  • [H|S|Z|CO]SCAN with too few parameters should return an error
  • GEO commands (except GEODIST) should return an array of null arrays
  • GEOADD with CH and NX options should include added items in output count
  • RUNTXP with too few parameters should return an error

Added tests for all cases described

@badrishc
Copy link
Contributor

cc @kevin-montrose

@TalZaccai TalZaccai requested a review from yrajas May 28, 2024 18:09
@TalZaccai TalZaccai merged commit 72e7504 into main May 29, 2024
26 checks passed
@TalZaccai TalZaccai deleted the talzacc/bugfixes_new branch May 29, 2024 19:00
chyin6 pushed a commit to jusjin-org/garnet that referenced this pull request Jul 2, 2024
@TalZaccai @badrishc @chyin6
Various API bugfixes (microsoft#417)
86998ea 
* tmp - GeoAdd broken

* reverting changes to GeoAdd

* more bugfixes

* broken test fix

* small comment fix

---------

Co-authored-by: Badrish Chandramouli <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badrishc badrishc badrishc left review comments

@yrajas yrajas yrajas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TalZaccai @badrishc @yrajas