Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: Add support for configuration from a secret #531

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MartinHell
Copy link

Hi,

I noticed there's no support for using garnet.conf instead of command line arguments. This aims to fix that by adding support for a secret or using an existingSecret.

If you configure Auth and Passwords currently you can't really store the values.yaml in version control since it would contain the password in clear text. This will allow you to add sensitive information (password) to a secret, you could store it using SealedSecrets or something similar in git and apply that secret alongside the helm chart for example.

Hopefully this is appreciated :)

@yrajas yrajas requested a review from msft-paddy14 July 26, 2024 19:10
@MartinHell
Copy link
Author

@microsoft-github-policy-service agree

@badrishc
Copy link
Contributor

badrishc commented Aug 5, 2024

cc @babykart @nicholih for review

@babykart
Copy link
Contributor

babykart commented Aug 5, 2024

We are already in a helm chart called garnet so let's avoid any potential confusion or repetition (?).

config:
  # -- Garnet secret (if you want to use an existing secret)
  # Make sure the key in the secret is 'garnet.conf'
  existingSecret: ""
  # -- The garnet.conf data content.
  garnetConf: ""
  # garnetConf: |
  #   {
  #     "AuthenticationMode": "Password",
  #     "Password": ""
  #   }

@msft-paddy14
Copy link
Contributor

The idea seems right but we should use existing charts as pointed out by @babykart . Generally how we do it in Kubernetes is to have a sidecar init container where we fetch the secrets (say from Azure Key Vault) based on secret name and keyvault name. We use the ACL mode to apply it as a file mount during startup. For just password usage, something similar can be done by updating the garnet.conf in place. It might be something you want to do using dependent helm charts so that you can add your chart while referring garnet one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants