-
Notifications
You must be signed in to change notification settings - Fork 525
add action to translate readme #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…emove unnecessary branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First iteration added. Some of the prompts are reaching 16k tokens and hitting the upper limit. Chunking documents will certainly help with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed french translations and it's quite good!
Few questions though:
- Is there a global config file that we can use to set global translations rules, like for example avoid translating specific words?
- Is the cache shared between file, so an exact same paragraph in different files would be translated the same, for consistency? (and less token usage 🙂 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to exclude specific words to be translated? Like for example "prompt"? Do you think we can use frontmatter metadata for that?
Consultez l'[application d'exemple](/app/README.md) pour commencer. | ||
> \[!ASTUCE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This [!TIP] should not be translated. A good candidate for global rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right this is a bug. We should be handling the GFM annotation specifically and ignore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few broken translations in the cache. I will remove them and rerun the translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some untranslated text parts here, might need to see if it's the model and how it can be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes, the validation refuses the translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these refusals be tagged in the translation cache?
|
||
## Récit - De Charybde en Scylla | ||
|
||
> > [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double >
here, not sure why? maybe trying to recompile the MD node after translation to see the same node structure was kept might help with issues like these?
|
||
## Ressources d'auto-apprentissage | ||
|
||
* [\* \[Série de vidéos sur l'intelligence artificielle générative avec JavaScript\](https://aka.ms/genai-js)](https://aka.ms/genai-js) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems something wrong there with the link
This pull request configure AI-generated translations for french (only lessons and readme) using github actions and github models. Large files are still a bit of a problem, good start.