refactor(build): switch to @nx/js:tsc executor#801
Open
layershifter wants to merge 4 commits intomicrosoft:mainfrom
Open
refactor(build): switch to @nx/js:tsc executor#801layershifter wants to merge 4 commits intomicrosoft:mainfrom
layershifter wants to merge 4 commits intomicrosoft:mainfrom
Conversation
📊 Bundle size report✅ No changes found |
…o @nx/js:tsc Replace @nx/vite:build with @nx/js:tsc executor for these three packages. This uses the TypeScript compiler directly instead of bundling via Rollup, producing individual output files matching the source structure. - Update project.json build targets to use @nx/js:tsc - Update package.json exports to use "default" condition (compatible with bundler resolution) - Add module: "ESNext" + moduleResolution: "bundler" to tsconfig.lib.json - Delete vite.config.ts (was build+test), create vitest.config.mts (test-only) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a5fe818 to
d9cf8d7
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@griffel/transform,@griffel/transform-shaker, and@griffel/webpack-pluginfrom@nx/vite:buildto@nx/js:tscexecutorvite.config.ts(combined build+test config), create standalonevitest.config.mts(test-only)Key details
tsconfig.lib.jsonusesmodule: "ESNext"+moduleResolution: "bundler"to work with@nx/js:tscdependency path remapping"default"condition (universal) instead of"node"(which isn't matched by bundler resolution)main/typesfields inpackage.jsonto work around@nx/js:tscincorrect.mts→.d.mtsextension mappingTest plan
npx nx run-many -t build -p transform transform-shaker webpack-pluginnpx nx run-many -t test -p transform transform-shaker webpack-pluginnpx nx run-many -t type-check -p transform transform-shaker webpack-plugin🤖 Generated with Claude Code