refactor(e2e-rspack): switch to @griffel/webpack-plugin#806
Draft
layershifter wants to merge 2 commits intomicrosoft:mainfrom
Draft
refactor(e2e-rspack): switch to @griffel/webpack-plugin#806layershifter wants to merge 2 commits intomicrosoft:mainfrom
layershifter wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…o @nx/js:tsc Replace @nx/vite:build with @nx/js:tsc executor for these three packages. This uses the TypeScript compiler directly instead of bundling via Rollup, producing individual output files matching the source structure. - Update project.json build targets to use @nx/js:tsc - Update package.json exports to use "default" condition (compatible with bundler resolution) - Add module: "ESNext" + moduleResolution: "bundler" to tsconfig.lib.json - Delete vite.config.ts (was build+test), create vitest.config.mts (test-only) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…_RSPACK branches Switch e2e-rspack from deprecated @griffel/webpack-extraction-plugin + @griffel/webpack-loader to the unified @griffel/webpack-plugin. Remove unnecessary IS_RSPACK conditionals in the plugin and loader now that Rspack supports NormalModule.getCompilationHooks and namedChunks.get(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-rspackfrom deprecated@griffel/webpack-extraction-plugin+@griffel/webpack-loaderto the unified@griffel/webpack-pluginIS_RSPACKconditionals in the plugin and loader now that Rspack supportsNormalModule.getCompilationHooksandnamedChunks.get()Test plan
🤖 Generated with Claude Code