fix(transform-shaker): fix export * as ns handling and guard structural children#816
Merged
layershifter merged 3 commits intomainfrom Mar 13, 2026
Merged
Conversation
📊 Bundle size report✅ No changes found |
layershifter
force-pushed
the
fix/vm-error-wrapping-and-shaker-structural-children
branch
from
e9e9aee to
4a9cec1
Compare
…aker structural child removal - Wrap vm.runInContext() errors in Module.evaluate() as proper host Error instances with filename context, fixing NonErrorEmittedError in webpack - Add ExportAllDeclaration.exported edge in graph builder, distinguishing `export * as ns` (named export) from `export *` (wildcard re-export) - Guard syntactically required children (source, exported) from removal in removeDeadCode(), preventing invalid ESM output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
layershifter
force-pushed
the
fix/vm-error-wrapping-and-shaker-structural-children
branch
from
4a9cec1 to
20ab490
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
layershifter
changed the title
jurokapsiar
approved these changes
Mar 13, 2026
layershifter
deleted the
fix/vm-error-wrapping-and-shaker-structural-children
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export * as nshandling — graph builder now correctly treatsexport * as ns from "module"as a named export (not a wildcard re-export), preventing incorrect tree-shaking behavior.removeDeadCode()no longer removes syntactically required children (source,exportedon export/import declarations,CatchClause.param,LabeledStatement.label, loop test expressions), preventing invalid ESM output.Test plan
npx nx test transform-shaker— all tests pass (includes 2 newexport * as nstests)npx nx test webpack-plugin— all tests pass (no regressions)🤖 Generated with Claude Code