perf(transform): skip eval cache for __mkPreval evaluations#818
Merged
layershifter merged 2 commits intomainfrom Mar 13, 2026
Merged
perf(transform): skip eval cache for __mkPreval evaluations#818layershifter merged 2 commits intomainfrom
layershifter merged 2 commits intomainfrom
Conversation
layershifter
force-pushed
the
perf/skip-eval-cache-mkpreval
branch
from
6c548a7 to
32637d3
Compare
__mkPreval is the unique entry-point evaluation per source file — each call has unique sourceCode + expressionCode, so the eval cache never hits. Add useEvalCache parameter to Module.evaluate() and pass false from vmEvaluator. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
layershifter
force-pushed
the
perf/skip-eval-cache-mkpreval
branch
from
32637d3 to
6482276
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jurokapsiar
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEvalCacheparameter toModule.evaluate()to allow callers to opt out of eval cachingvmEvaluatorpassesuseEvalCache=false— each source file produces uniquecodeForEvaluation(differentsourceCode+expressionCode), so the eval cache would never hit and we'd just waste time on SHA-1 hashing and map storagerequire()keep the defaultuseEvalCache=trueTest plan
npx nx test transform— 73 tests pass🤖 Generated with Claude Code