Skip to content

feat(skills): add privacy-by-design skill with PbD 7 Foundation Principles assessment - #2635

Open
Yogi (yogitasrivastava) wants to merge 5 commits into
microsoft:mainfrom
yogitasrivastava:feat/privacy-by-design-skill
Open

feat(skills): add privacy-by-design skill with PbD 7 Foundation Principles assessment#2635
Yogi (yogitasrivastava) wants to merge 5 commits into
microsoft:mainfrom
yogitasrivastava:feat/privacy-by-design-skill

Conversation

@yogitasrivastava

Copy link
Copy Markdown

Summary

Adds a new privacy-by-design skill under .github/skills/project-planning/ that encodes the Cavoukian 7 Foundation Principles of Privacy by Design as structured, agent-consumable assessment references.

What this delivers

File Purpose
SKILL.md Skill entrypoint with when-to-use, layout, integration notes, attribution

|
eferences/00-principle-index.md | Principle catalog with regulatory cross-reference matrix |
|
eferences/01-07 | One file per PbD principle with checklist, controls, anti-patterns, regulatory mappings |
|
eferences/data-retention-and-disposal.md | Principle 05 deep-dive: retention schedules, disposal methods, legal holds |
|
eferences/cross-jurisdictional-mapping.md | GDPR / CCPA-CPRA / APP equivalence matrix |

Key differentiators

  • Structured assessment criteria — each principle has observable PASS/FAIL/PARTIAL indicators with severity ratings
  • Cross-jurisdictional coverage — maps all 7 principles across GDPR Art. 25, CCPA/CPRA, and Australian Privacy Principles (APP)
  • Data retention and disposal — full lifecycle guidance under Principle 05 including legal holds, backup considerations, disposal verification
  • Agent-ready architecture — feeds Privacy Reviewer and Privacy Planner without agent modification (same pattern as owasp-* skills feeding security-reviewer)
  • Complements privacy-standards — extends the NIST PF/GDPR/CCPA/OWASP backbone with principle-level assessment

Value proposition

Without this skill With this skill
Privacy Reviewer assesses only against NIST PF, GDPR, CCPA, OWASP Privacy Risks Also assesses against PbD principles, retention/disposal compliance, and APP
No structured checks for 'is privacy the default?' or 'is data disposed securely?' Principle-by-principle structured findings with severity ratings
No Australian Privacy Principles coverage Cross-jurisdictional coverage (GDPR + CCPA + APP)

Checklist

  • Follows existing skill structure (mirrors secure-by-design, owasp-top-10 patterns)
  • Includes attribution and licensing posture
  • No executable scripts (markdown knowledge-base skill)
  • Cross-references privacy-standards skill for integration context

Refs: #2594

…iples

Add a new privacy-by-design skill under project-planning that encodes
the Cavoukian 7 Foundation Principles as structured, agent-consumable
assessment references. Includes:

- SKILL.md entrypoint with when-to-use guidance and integration notes
- Per-principle references (01-07) with checklists, controls, anti-patterns,
  and cross-references to GDPR Art. 25, CCPA/CPRA, and Australian APP
- Data retention and disposal deep-dive (Principle 05 expansion)
- Cross-jurisdictional regulatory equivalence matrix
- Finding severity and verdict conventions for PASS/FAIL/PARTIAL assessment

Complements privacy-standards skill; loaded by Privacy Reviewer and
Privacy Planner agents on demand without agent modification.

Refs: microsoft#2594
@yogitasrivastava
Yogi (yogitasrivastava) requested a review from a team as a code owner August 9, 2026 14:02
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.92%. Comparing base (db1be8f) to head (5615924).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
+ Coverage   82.85%   82.92%   +0.06%     
==========================================
  Files         166      152      -14     
  Lines       22521    22146     -375     
  Branches       29        0      -29     
==========================================
- Hits        18660    18364     -296     
+ Misses       3858     3782      -76     
+ Partials        3        0       -3     
Flag Coverage Δ
docusaurus ?
pester 86.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…tion patterns

Deepen the privacy-by-design skill with operational references that make
it agent-ready and pragmatic:

- assessment-protocol.md: 5-phase protocol (scope, principle assessment,
  retention check, cross-jurisdictional check, synthesis) with verdict
  rules, severity rules, evidence expectations, and stop rules
- finding-schema.md: YAML-based structured output schema with finding
  records, assessment summaries, retention extensions, and backlog
  handoff templates compatible with hve-core review workflow
- implementation-patterns.md: code-level and config-level verification
  patterns agents can check (consent mechanisms, default settings,
  encryption, retention enforcement, CI/CD privacy checks, IaC patterns)

Update SKILL.md to hve-builder outcome-first standards:
- Add Goal, Success criteria, and Stop rules sections
- Add Overall assessment verdicts table
- Add Interaction with other skills cross-reference table
- Reference new operational documents in skill layout

Refs: microsoft#2594
…nfig

Add industry-privacy-profiles.md mapping PbD principles to sector-specific
contexts (telco, healthcare, financial services) with:

- Per-industry principle priority weighting (which principles matter most)
- Industry-specific assessment checks beyond universal checklists
- Key regulatory references per sector
- .pbd-config.yml schema for project-level customization:
  - Industry selection
  - Principle priority overrides with justification
  - Custom checks (org-specific requirements)
  - Suppressions for inapplicable checks

Integration: Privacy Reviewer loads config, adjusts checklist weighting,
adds industry checks, and elevates findings based on sector priorities.

Refs: microsoft#2594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants