feat(skills): add privacy-pii-detector skill with industry-specific PII detection and control verification - #2636
Open
Yogi (yogitasrivastava) wants to merge 5 commits into
Conversation
Add a new privacy-pii-detector skill that automatically detects PII/PI processing in codebases, classifies by sensitivity tier, verifies privacy controls exist, and raises findings for unprotected data. Requires zero privacy expertise from the user. Core capability: - 3-tier PII taxonomy (Identifiers, Sensitive, Special Category) with 47+ core types and regulatory anchors - Detection patterns: naming conventions, format validation, schema definitions, API signatures, third-party SDKs, log/telemetry leaks - Control expectations matrix: required controls per tier with verification methods (encryption, access control, masking, retention, consent, audit logging, purpose binding) - Structured finding schema with backlog handoff template Industry overlays (extensible architecture): - Telco: IMEI, IMSI, MSISDN, CDR, cell tower, SIM serial, roaming data, ePrivacy controls - Healthcare: MRN, diagnoses, medications, genetic data, FHIR resource mapping, HIPAA/42 CFR Part 2 controls - Financial: PAN, CVV, account numbers, credit scores, KYC, PCI DSS controls, AML/CTF obligations Architecture: core taxonomy + pluggable industry overlays (1N-*.md) so new industries can be added without modifying existing files.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
+ Coverage 82.85% 82.92% +0.06%
==========================================
Files 166 152 -14
Lines 22521 22146 -375
Branches 29 0 -29
==========================================
- Hits 18660 18364 -296
+ Misses 3858 3782 -76
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…customization Add 04-custom-classification.md defining .pii-config.yml schema that allows projects to bring their own data classification: - Custom PII types (org-specific data categories with detection patterns) - Tier overrides (upgrade/downgrade built-in types per org policy) - Additional controls (require extra controls beyond tier defaults) - Suppressions (suppress known false positives with file-scoped globs) - Catalog import (Microsoft Purview label mapping, CSV/JSON import) - Retention overrides (org-specific retention periods with justification) - Resolution order: suppressions → custom → overrides → industry → core Update SKILL.md to reference new file and load config in Phase 1. Refs: microsoft#2594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new privacy-pii-detector skill that automatically detects PII/PI in codebases, classifies by sensitivity tier, verifies privacy controls exist, and raises findings when protections are missing. Requires zero privacy expertise from the user.
Problem this solves
Developers without privacy training have no way to know:
This skill fills that gap by making the Privacy Reviewer agent capable of automatic detection rather than requiring human-initiated assessment.
What this delivers (8 files, 1,074 lines)
Architecture: Core + Industry Overlays
\
privacy-pii-detector/
├── SKILL.md # Entrypoint + protocol
├── references/
│ ├── 00-pii-taxonomy.md # Universal PII (all industries)
│ ├── 01-detection-patterns.md # How to find PII in code
│ ├── 02-control-expectations.md # What controls must exist
│ ├── 03-finding-schema.md # Output format
│ ├── 10-industry-telco.md # Telco-specific PII + controls
│ ├── 11-industry-healthcare.md # Healthcare-specific PII + controls
│ └── 12-industry-financial.md # Financial-specific PII + controls
\\
Extensible: New industries added as \1N-industry-.md\ without modifying existing files.
How it differs from existing privacy skills
Checklist