docs: fix data classification reference link - #2774
docs: fix data classification reference link#2774Shaurya Saria (icecold009) wants to merge 3 commits into
Conversation
Jamie Kim (jkim323)
left a comment
Jamie Kim (jkim323)
left a comment
There was a problem hiding this comment.
Thank you Shaurya Saria (@icecold009) for working on this PR. So far looks great but have a couple asks for you to review. Please ensure you also follow the PR Template guidelines and update with following the local checks required. Happy to review again after you take a look at the comments!
|
|
||
| * Microsoft Purview sensitivity labels: <https://learn.microsoft.com/purview/sensitivity-labels> | ||
| * Microsoft data classification categories (Customer Data, EUII, EUPI, OII): <https://learn.microsoft.com/compliance/assurance/assurance-data-classification> | ||
| - Microsoft data classification and sensitivity label taxonomy: <https://learn.microsoft.com/en-us/compliance/assurance/assurance-data-classification-and-labels> |
There was a problem hiding this comment.
The replacement URL still includes the /en-us/ locale segment. npm run lint:links invokes Invoke-LinkLanguageCheck.ps1, which flags this pattern, and validate:local includes that gate.
Suggested fix: Please use the locale-neutral URL (https://learn.microsoft.com/compliance/assurance/assurance-data-classification-and-labels) so this fix does not introduce a new validation failure.
| Personal, Public, General, Confidential, and Highly Confidential. | ||
| - Public Microsoft material also uses broad categories such as Customer Data, | ||
| EUII, EUPI, OII, and System or Organizational data. | ||
| - Public Microsoft material describes data classification frameworks and |
There was a problem hiding this comment.
The replacement taxonomy page does not mention “Customer Data”; it documents classification levels such as Public, General, Confidential, and Highly Confidential. Because this reference is the skill’s source anchor, retaining Customer Data still makes the surrounding claim exceed its citation and does not fully meet #2758’s requirement that the source support the named terminology.
Suggested fix:
- Microsoft's public service-assurance taxonomy documents a classification
framework whose levels are Public, General, Confidential, and Highly
Confidential, and records that the level formerly named Internal is now
General. The asset-role category names above are this reference's own
vendor-neutral vocabulary and are not drawn from that page.|
|
||
| * Microsoft Purview sensitivity labels: <https://learn.microsoft.com/purview/sensitivity-labels> | ||
| * Microsoft data classification categories (Customer Data, EUII, EUPI, OII): <https://learn.microsoft.com/compliance/assurance/assurance-data-classification> | ||
| - Microsoft data classification and sensitivity label taxonomy: <https://learn.microsoft.com/en-us/compliance/assurance/assurance-data-classification-and-labels> |
There was a problem hiding this comment.
Please retain * for this source entry. The preceding sibling already uses *, and the repository’s Markdown conventions require consistent unordered-list markers at the same level, preferring asterisks. Using - here also splits the two source entries into adjacent one-item lists under CommonMark.
Suggested fix:
* Microsoft Purview sensitivity labels: <https://learn.microsoft.com/purview/sensitivity-labels>
* Microsoft data classification and sensitivity label taxonomy: <https://learn.microsoft.com/compliance/assurance/assurance-data-classification-and-labels>| - Microsoft Purview default sensitivity labels use a public ladder such as | ||
| Personal, Public, General, Confidential, and Highly Confidential. | ||
| - Public Microsoft material also uses broad categories such as Customer Data, | ||
| EUII, EUPI, OII, and System or Organizational data. | ||
| - Public Microsoft material describes data classification frameworks and | ||
| sensitivity labels, including categories and labels such as Customer Data, | ||
| Public, General, Confidential, and Highly Confidential. |
There was a problem hiding this comment.
After removing the unsupported Customer Data term, this bullet repeats the same Public/General/Confidential/Highly Confidential ladder already provided by the Purview bullet above. The new source has a distinct, directly relevant fact that would avoid duplication: it says Microsoft moved from the former Internal label to General.
Suggested fix: Please reword this anchor around that framework and naming guidance instead of restating the sensitivity ladder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
==========================================
- Coverage 82.98% 82.95% -0.04%
==========================================
Files 183 171 -12
Lines 33788 33649 -139
Branches 25 0 -25
==========================================
- Hits 28039 27913 -126
+ Misses 5746 5736 -10
+ Partials 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3 participants
Summary
Closes #2758
Testing
npx --no-install markdownlint-cli2 .github/skills/project-planning/security-planning/references/data-classification.md— passed.npx --no-install cspell .github/skills/project-planning/security-planning/references/data-classification.md— passed.git diff --check— passed.