Skip to content

Add /workspace command for agent session snapshot and restore#310

Open
ashishpatel26 wants to merge 2 commits into
microsoft:mainfrom
ashishpatel26:fix/issue-193-agent-workspace
Open

Add /workspace command for agent session snapshot and restore#310
ashishpatel26 wants to merge 2 commits into
microsoft:mainfrom
ashishpatel26:fix/issue-193-agent-workspace

Conversation

@ashishpatel26

Copy link
Copy Markdown

Closes #193

Summary

  • New /workspace save [name] command saves the current agent session state (session key, CLI source, working directory) to a named slot
  • New /workspace list command shows all saved workspace names
  • Snapshots persist to workspaces.json in the user config directory and survive Terminal restarts
  • Module workspace_snapshot with full public API: save(), load(), list(), delete()
  • commands.workspace.summary i18n key added to all 89 locale files to satisfy the parity test
  • tempfile dev-dependency added for the snapshot unit tests

Testing

All 912 existing tests pass. Two new slash command tests added:

  • slash_workspace_list_when_no_snapshots_shows_system_message
  • slash_workspace_unknown_subcommand_shows_usage

Introduces workspace snapshots: named captures of an agent session's
state (session key, CLI source, working directory) that survive Terminal
restarts. The /workspace command provides save and list subcommands;
snapshots persist to workspaces.json in the user's config directory.

Closes microsoft#193
Copilot AI review requested due to automatic review settings June 17, 2026 05:34
@microsoft-github-policy-service

Copy link
Copy Markdown

@ashishpatel26 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds workspace snapshot persistence and /workspace slash-command support, plus introduces a new app event to feed terminal command output back into the agent for multi-turn execution.

Changes:

  • Introduces workspace_snapshot module for saving/listing/loading/deleting snapshots persisted to workspaces.json
  • Adds /workspace save [name] and /workspace list command plumbing and tests
  • Adds AppEvent::CommandOutputReady and follow-up prompt submission; updates i18n strings and dev test dependency

Reviewed changes

Copilot reviewed 95 out of 96 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/wta/src/workspace_snapshot.rs New snapshot store model + JSON persistence helpers + unit tests
tools/wta/src/slash_command_tests.rs Adds tests for /workspace list empty state and unknown subcommand usage
tools/wta/src/main.rs Registers the new workspace_snapshot module
tools/wta/src/commands.rs Adds workspace command spec and help summary key
tools/wta/src/app.rs Implements /workspace handler; adds CommandOutputReady event and handler; passes session_id into choice execution
tools/wta/locales/en-US.yml Adds commands.workspace.summary string
tools/wta/locales/en-GB.yml Adds commands.workspace.summary string
tools/wta/locales/zh-TW.yml Adds commands.workspace.summary string
tools/wta/locales/zh-CN.yml Adds commands.workspace.summary string
tools/wta/locales/vi-VN.yml Adds commands.workspace.summary string
tools/wta/locales/uz-Latn-UZ.yml Adds commands.workspace.summary string
tools/wta/locales/ur-PK.yml Adds commands.workspace.summary string
tools/wta/locales/uk-UA.yml Adds commands.workspace.summary string
tools/wta/locales/ug-CN.yml Adds commands.workspace.summary string
tools/wta/locales/tt-RU.yml Adds commands.workspace.summary string
tools/wta/locales/tr-TR.yml Adds commands.workspace.summary string
tools/wta/locales/th-TH.yml Adds commands.workspace.summary string
tools/wta/locales/te-IN.yml Adds commands.workspace.summary string
tools/wta/locales/ta-IN.yml Adds commands.workspace.summary string
tools/wta/locales/sv-SE.yml Adds commands.workspace.summary string
tools/wta/locales/sr-Latn-RS.yml Adds commands.workspace.summary string
tools/wta/locales/sr-Cyrl-RS.yml Adds commands.workspace.summary string
tools/wta/locales/sr-Cyrl-BA.yml Adds commands.workspace.summary string
tools/wta/locales/sq-AL.yml Adds commands.workspace.summary string
tools/wta/locales/sl-SI.yml Adds commands.workspace.summary string
tools/wta/locales/sk-SK.yml Adds commands.workspace.summary string
tools/wta/locales/ru-RU.yml Adds commands.workspace.summary string
tools/wta/locales/ro-RO.yml Adds commands.workspace.summary string
tools/wta/locales/quz-PE.yml Adds commands.workspace.summary string
tools/wta/locales/qps-plocm.yml Adds pseudo-loc commands.workspace.summary string
tools/wta/locales/qps-ploca.yml Adds pseudo-loc commands.workspace.summary string
tools/wta/locales/qps-ploc.yml Adds pseudo-loc commands.workspace.summary string
tools/wta/locales/pt-PT.yml Adds commands.workspace.summary string
tools/wta/locales/pt-BR.yml Adds commands.workspace.summary string
tools/wta/locales/pl-PL.yml Adds commands.workspace.summary string
tools/wta/locales/pa-IN.yml Adds commands.workspace.summary string
tools/wta/locales/or-IN.yml Adds commands.workspace.summary string
tools/wta/locales/nn-NO.yml Adds commands.workspace.summary string
tools/wta/locales/nl-NL.yml Adds commands.workspace.summary string
tools/wta/locales/ne-NP.yml Adds commands.workspace.summary string
tools/wta/locales/nb-NO.yml Adds commands.workspace.summary string
tools/wta/locales/mt-MT.yml Adds commands.workspace.summary string
tools/wta/locales/ms-MY.yml Adds commands.workspace.summary string
tools/wta/locales/mr-IN.yml Adds commands.workspace.summary string
tools/wta/locales/ml-IN.yml Adds commands.workspace.summary string
tools/wta/locales/mk-MK.yml Adds commands.workspace.summary string
tools/wta/locales/mi-NZ.yml Adds commands.workspace.summary string
tools/wta/locales/lv-LV.yml Adds commands.workspace.summary string
tools/wta/locales/lt-LT.yml Adds commands.workspace.summary string
tools/wta/locales/lo-LA.yml Adds commands.workspace.summary string
tools/wta/locales/lb-LU.yml Adds commands.workspace.summary string
tools/wta/locales/kok-IN.yml Adds commands.workspace.summary string
tools/wta/locales/ko-KR.yml Adds commands.workspace.summary string
tools/wta/locales/kn-IN.yml Adds commands.workspace.summary string
tools/wta/locales/km-KH.yml Adds commands.workspace.summary string
tools/wta/locales/kk-KZ.yml Adds commands.workspace.summary string
tools/wta/locales/ka-GE.yml Adds commands.workspace.summary string
tools/wta/locales/ja-JP.yml Adds commands.workspace.summary string
tools/wta/locales/it-IT.yml Adds commands.workspace.summary string
tools/wta/locales/is-IS.yml Adds commands.workspace.summary string
tools/wta/locales/id-ID.yml Adds commands.workspace.summary string
tools/wta/locales/hy-AM.yml Adds commands.workspace.summary string
tools/wta/locales/hu-HU.yml Adds commands.workspace.summary string
tools/wta/locales/hr-HR.yml Adds commands.workspace.summary string
tools/wta/locales/hi-IN.yml Adds commands.workspace.summary string
tools/wta/locales/he-IL.yml Adds commands.workspace.summary string
tools/wta/locales/gu-IN.yml Adds commands.workspace.summary string
tools/wta/locales/gl-ES.yml Adds commands.workspace.summary string
tools/wta/locales/gd-gb.yml Adds commands.workspace.summary string
tools/wta/locales/ga-IE.yml Adds commands.workspace.summary string
tools/wta/locales/fr-FR.yml Adds commands.workspace.summary string
tools/wta/locales/fr-CA.yml Adds commands.workspace.summary string
tools/wta/locales/fil-PH.yml Adds commands.workspace.summary string
tools/wta/locales/fi-FI.yml Adds commands.workspace.summary string
tools/wta/locales/fa-IR.yml Adds commands.workspace.summary string
tools/wta/locales/eu-ES.yml Adds commands.workspace.summary string
tools/wta/locales/et-EE.yml Adds commands.workspace.summary string
tools/wta/locales/es-MX.yml Adds commands.workspace.summary string
tools/wta/locales/es-ES.yml Adds commands.workspace.summary string
tools/wta/locales/el-GR.yml Adds commands.workspace.summary string
tools/wta/locales/de-DE.yml Adds commands.workspace.summary string
tools/wta/locales/da-DK.yml Adds commands.workspace.summary string
tools/wta/locales/cy-GB.yml Adds commands.workspace.summary string
tools/wta/locales/cs-CZ.yml Adds commands.workspace.summary string
tools/wta/locales/ca-Es-VALENCIA.yml Adds commands.workspace.summary string
tools/wta/locales/ca-ES.yml Adds commands.workspace.summary string
tools/wta/locales/bs-Latn-BA.yml Adds commands.workspace.summary string
tools/wta/locales/bn-IN.yml Adds commands.workspace.summary string
tools/wta/locales/bg-BG.yml Adds commands.workspace.summary string
tools/wta/locales/az-Latn-AZ.yml Adds commands.workspace.summary string
tools/wta/locales/as-IN.yml Adds commands.workspace.summary string
tools/wta/locales/ar-SA.yml Adds commands.workspace.summary string
tools/wta/locales/am-ET.yml Adds commands.workspace.summary string
tools/wta/locales/af-ZA.yml Adds commands.workspace.summary string
tools/wta/Cargo.toml Adds tempfile dev-dependency for new unit tests
Comments suppressed due to low confidence (6)

tools/wta/src/app.rs:1

  • Slicing String by byte index can panic when session_key contains non-ASCII (slice boundary may not be on a UTF-8 char boundary). Use a safe truncation approach (e.g., chars().take(8) or get(..8).unwrap_or(...) with a char-boundary search) to avoid runtime panics.
    tools/wta/src/workspace_snapshot.rs:1
  • The module-level docs describe /workspace restore [name], but the implemented command handler in App::cmd_workspace only supports save and list. Please either implement the restore subcommand (likely using load() and opening a new tab/session) or update the docs and related user-facing strings to match the actual behavior.
    tools/wta/src/workspace_snapshot.rs:1
  • load_store currently treats any read error and any JSON parse error as 'no snapshots' by returning default(). This will silently hide important problems like permission errors or a corrupted workspaces.json, and /workspace list will incorrectly report 'No saved workspaces.' Consider returning a Result<SnapshotStore, io::Error/serde_json::Error> (or mapping to your String error) and only falling back to empty on ErrorKind::NotFound.
    tools/wta/src/workspace_snapshot.rs:1
  • Writing JSON directly to the destination path is not crash-safe: if the process is terminated mid-write, workspaces.json can become truncated/corrupted and all snapshots may be lost. Prefer an atomic write strategy (write to a temp file in the same directory, fsync if needed, then rename over the target) to make snapshot persistence resilient.
    tools/wta/src/workspace_snapshot.rs:1
  • This test uses a hard-coded /tmp/... path, which is platform-specific (fails on Windows) and can be flaky if that file happens to exist. Use tempfile::tempdir() and join a guaranteed-nonexistent filename inside it (or create a NamedTempFile and delete it before calling) to make the test deterministic and cross-platform.
    tools/wta/locales/zh-CN.yml:1
  • Many non-English locale files add commands.workspace.summary but keep the value in English, and the text says 'restore' even though the command currently supports save|list. Consider (a) updating the string to match implemented subcommands, and (b) either providing translations or omitting the key in non-English locales so the app can fall back to en-US instead of showing untranslated English in localized UIs.

@github-actions

Copy link
Copy Markdown

@check-spelling-bot Report

⚠️ Dictionary not found

Problems were encountered retrieving check dictionaries (cspell:swift/src/swift.txt cspell:cpp/src/lang-keywords.txt cspell:python/src/common/extra.txt cspell:python/src/python/python.txt cspell:python/src/additional_words.txt cspell:rust/dict/rust.txt cspell:public-licenses/src/generated/public-licenses.txt cspell:dart/src/dart.txt cspell:cpp/src/stdlib-cerrno.txt cspell:cpp/src/template-strings.txt cspell:latex/dict/latex.txt cspell:dotnet/dict/dotnet.txt cspell:redis/dict/redis.txt cspell:python/src/python/python-lib.txt cspell:cpp/src/stdlib-cpp.txt cspell:fullstack/dict/fullstack.txt cspell:lua/dict/lua.txt cspell:svelte/dict/svelte.txt cspell:cpp/src/compiler-clang-attributes.txt cspell:cpp/src/compiler-msvc.txt cspell:java/src/java.txt cspell:ada/dict/ada.txt cspell:cpp/src/people.txt cspell:css/dict/css.txt cspell:public-licenses/src/additional-licenses.txt cspell:software-terms/dict/webServices.txt cspell:cpp/src/stdlib-cmath.txt cspell:npm/dict/npm.txt cspell:sql/src/sql.txt cspell:monkeyc/src/monkeyc_keywords.txt cspell:powershell/dict/powershell.txt cspell:elixir/dict/elixir.txt cspell:gaming-terms/dict/gaming-terms.txt cspell:docker/src/docker-words.txt cspell:ruby/dict/ruby.txt cspell:r/src/r.txt cspell:k8s/dict/k8s.txt cspell:clojure/src/clojure.txt cspell:java/src/java-terms.txt cspell:scala/dict/scala.txt cspell:shell/dict/shell-all-words.txt cspell:cpp/src/compiler-gcc.txt cspell:html/dict/html.txt cspell:cpp/src/ecosystem.txt cspell:software-terms/dict/softwareTerms.txt cspell:sql/src/tsql.txt cspell:php/dict/php.txt cspell:django/dict/django.txt cspell:typescript/dict/typescript.txt cspell:haskell/dict/haskell.txt cspell:node/dict/node.txt cspell:cpp/src/stdlib-c.txt cspell:cpp/src/lang-jargon.txt cspell:golang/dict/go.txt).

⚠️ For more information, see check-dictionary-not-found.

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (3)

remotesigned
segfaults
Subscribe'd

These words are not needed and should be removed allsigned Backgrounder CANTCALLOUT Ccc cplusplus ctl Debian dotnet drv endptr EOFs evt Fullwidth gitlab hdr idl IME inbox ININPUTSYNCCALL intelligentterminal Ioctl KVM lbl lld lsb NODEFAULT NONINFRINGEMENT notif oss outdir Podcast pri prioritization rcv segfault SND sourced SWP Tbl testname transitioning unk unparseable unregisters Virt VMs webpage websites WINVER xsi

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:ashishpatel26/intelligent-terminal.git repository
on the fix/issue-193-agent-workspace branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/intelligent-terminal/actions/runs/27689485919/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (2064) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt and unrecognized words (3)

Dictionary Entries Covers Uniquely
cspell:csharp/csharp.txt 32 2 2
cspell:aws/aws.txt 232 2 2
cspell:fonts/fonts.txt 536 1 1

Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):

    "cspell:csharp/csharp.txt",
    "cspell:aws/aws.txt",
    "cspell:fonts/fonts.txt",

To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):

"check_extra_dictionaries": []

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Should be reentrancy
[Rr]e[- ]entrancy
Errors and Warnings ❌ (2)

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

❌ Errors and Warnings Count
⚠️ check-dictionary-not-found 54
❌ forbidden-pattern 1

See ❌ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@ashishpatel26

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent Workspace

2 participants