integration tests: sync with latest feature#377
Merged
Conversation
Reviewed the release checklist against the v0.1.2 release notes and fixed two outdated statements plus added seven missing test cases for new features. Outdated statements corrected: - Session view refresh: now F5 on-demand re-scan (incl. WSL distros started after launch), not gated on hooks (#344). - Historical state: history is now sourced from ACP session/list, not on-disk file parsing (#365). Missing test cases added: - Alt+V clipboard image paste into agent chat (#354) - GitHub Enterprise Copilot sign-in (#362) - Bash/WSL shell integration incl. set -u safety (#340) - Shells self-report identity via OSC 9001;ShellType + nested-shell autofix targeting (#345) - Environment-aware answers/fixes: investigate PATH before answering/autofixing (#306) - WSL distro sessions visible and resumable in the correct distro (#323) - Agent panes not persisted into saved window layout (#360/#275) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v0.1.2 release validation checklist (doc/release-check-list.md) so the manual/E2E sign-off steps match features that have landed since v0.1.1 (e.g., F5 refresh in sessions view, ACP-sourced session history, Alt+V image paste, GHE Copilot sign-in, shell identity reporting, WSL session visibility/resume, and non-persistence of agent panes in saved layouts).
Changes:
- Corrects outdated checklist statements for session-view refresh (F5) and historical session sourcing (ACP
session/list). - Adds new E2E/manual checklist items for v0.1.2 features (image paste, GHE sign-in, bash/WSL shell integration safety, OSC 9001 shell identity, PATH-aware behavior, WSL sessions, layout persistence behavior).
| - [ ] `[E2E]` **Prompt out-of-focus appearance is correct:** Input box looks correct when focus leaves the agent pane. | ||
| - [ ] `[E2E]` **Typing works:** User can type, edit, and submit prompt text correctly. | ||
| - [ ] `[E2E]` **Paste works:** Pasted multi-line text is handled correctly. | ||
| - [ ] `[UT✓]` `[E2E]` **Image paste (Alt+V) works:** A copied screenshot (`CF_DIB`/`CF_DIBV5`) or image file is sent to the agent as an ACP image content block; the action is gated on the agent advertising image support and is a no-op otherwise. _(UT: `clipboard_image` + `mock_agent_tests` `seen_images` side-channel; #354.)_ |
Contributor
Author
There was a problem hiding this comment.
Fixed in bca88d6 — reworded to say Alt+V queues the image until the next prompt, and an unsupported agent / empty clipboard surfaces a clear system message rather than being a silent no-op.
| - [ ] `[UT✓]` `[E2E]` **Focus active stashed agent pane:** Selecting an active stashed agent-pane session restores/focuses the pane if applicable. | ||
| - [ ] `[UT✓]` `[E2E]` **Restore old session:** Selecting a supported old session resumes it successfully. | ||
| - [ ] `[UT✓]` `[E2E]` **Restore old shell-pane session:** Supported shell-pane sessions resume through the CLI resume path. _(UT: `ResumeCliFlag` decision.)_ | ||
| - [ ] `[UT~]` `[E2E]` **WSL distro sessions are visible and resumable:** Agent-CLI sessions that were run *inside* a WSL distro appear in the session list tagged `[WSL-<distro>]`, and Enter resumes the session in that distro (via the wsl.exe ACP bridge). _(#323; UT: WSL session sourcing/classification.)_ |
Contributor
Author
There was a problem hiding this comment.
Resolved — this checklist item (WSL distro sessions, #323) was removed together with the WSL in-distro session rollback for v0.1.2, so the raw [WSL-]\ placeholder no longer appears in the doc.
This comment has been minimized.
This comment has been minimized.
Second review pass over the release checklist against the v0.1.2 release notes: - Added a [new] coverage marker to the legend and tagged all 12 genuinely-new v0.1.2 test cases with it (the two reworded existing cases — F5 refresh, ACP-sourced historical — are corrections, not new cases, so they stay untagged). - Added 5 more previously-missing cases surfaced by a closer read: - FRE execution-policy detection is correct / no false-block on probe timeout (#336/#338/#309) - wta-master death is a consistent degraded state requiring /restart, no split-brain (#329) - Session titles are clean (no bare '# AGENTS.md instructions' heading) (#355) - Focus brings the target window to the foreground (#353) - Agent-created terminals inherit the active pane profile (#366, closes #351) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…rop rolled-back WSL session checklist item Adds Feature.AgentMasterDeath.Tests.ps1: kills this app's wta-master out from under a live helper and asserts the full #329 contract end-to-end — the pane leaves Connected, the / popup is filtered to only /restart, NO master is silently respawned while degraded (anti-split-brain), and /restart brings up exactly one fresh master and reconnects. Verified passing live against the deployed dev package. Also removes the '[new] WSL distro sessions are visible and resumable' checklist item (#323) since WSL in-distro session support is being rolled back for v0.1.2, and drops the WSL example from the F5 refresh item to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| It 'killing wta-master enters a degraded state, blocks all slash commands but /restart, does not silently respawn, and recovers via /restart' { | ||
| # --- there is exactly one live master while connected --- | ||
| $masters = & $script:GetMasters | ||
| $masters.Count | Should -BeGreaterThan 0 -Because 'a connected agent pane implies a running wta-master' |
Contributor
Author
There was a problem hiding this comment.
Good catch — fixed in bca88d6. The assertion is now \Should -Be 1\ (exactly one shared wta-master per WindowsTerminal process, since SharedWta is a singleton), so this connected-state gate itself now catches a split-brain regression. Re-verified passing live.
This comment has been minimized.
This comment has been minimized.
…t+V behavior - Feature.AgentMasterDeath.Tests.ps1: assert exactly one wta-master while connected (-Be 1, was -BeGreaterThan 0) so the connected-state gate itself catches a split-brain regression. Re-verified passing live. - release-check-list.md: correct the Alt+V item — Alt+V queues the image until the next prompt, and an unsupported agent / empty clipboard surfaces a clear system message rather than being a silent no-op. The [WSL-<distro>] raw-angle-bracket comment is already resolved: that checklist item was removed with the WSL session rollback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…ecklist-v0.1.2 # Conflicts: # doc/release-check-list.md
| - `[UT~]` — partially UT-coverable: decision/logic core can be unit-tested, full behavior still needs E2E/UI. | ||
| - `[E2E]` — needs mock-ACP end-to-end or UI automation; not a UT. | ||
| - `[MANUAL]` — human judgment (visual polish, real LLM quality, install/auth UX). | ||
| - `[new]` — test case newly added for this release (v0.1.2); not exercised in a prior sign-off. Orthogonal to the coverage markers above — read it alongside the `[UT*]`/`[E2E]`/`[MANUAL]` marker. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
…elease-agnostic [new] marker, spelling fix - Feature.AgentMasterDeath.Tests.ps1: add /stop to the blocked-slash-command list so a regression that offers /stop while transport-lost is caught (it's a real CommandKind::Stop). Re-verified passing live. - release-check-list.md: reword the [new] marker in release-agnostic terms and say when to clear it (was hard-coded to v0.1.2); fix forbidden spelling non-existent -> nonexistent (check-spelling CI). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vanzue
changed the title
DDKinger
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed
doc/release-check-list.mdagainst the v0.1.2 release notes and brought it back in sync: fixed two now-outdated statements and added seven missing test cases for features shipped since v0.1.1.Outdated statements corrected
session/list, not on-disk file parsing. (#365)Missing test cases added
CF_DIB/CF_DIBV5, gated on agent image support). (feat(agent-pane): paste clipboard images into the chat with Alt+V (#211) #354)PROMPT_COMMANDsafe underset -u. (fix(shell-integration): bash PROMPT_COMMAND set -u safety + Agent Pane profile-count UTs #340)OSC 9001;ShellType+ nested-shell autofix targeting. (feat(shell): self-report shell identity via OSC 9001;ShellType #345)[WSL-<distro>]) and resumable in the correct distro. (Add WSL agent session management (historical visibility and resume) #323)Notes