Skip to content
This repository was archived by the owner on Jan 27, 2021. It is now read-only.

Conversation

@FLOAT4
Copy link

@FLOAT4 FLOAT4 commented Dec 22, 2017

Using importlib rather than import, helps support in Windows.
In addition, IVy lexer supports Unicode (for ‘forall’, ‘exists’, ‘->’, etc.). It should not change anything else, since the whole text is converted to Unicode only in the lexer itself, and after lexing converted back. However, invalid Unicode characters are handled differently.

@msftclas
Copy link

msftclas commented Dec 22, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ FLOAT4 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@kenmcmil
Copy link
Contributor

Hi Iddo,

These changes don't pass the regression suite. To run the tests. do this:

cd test
python run_expects.py
./runall

This runs two separate suites. The test framework doesn't work on Windows because of the limitations of the Windows version of "pexpect", so you have to run them on Linux.
It looks like there are both problems in parsing and problems importing modules.

Thanks -- Ken

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants